Skip to content

Fix #1626: replace dead WPI link for Taylor & McGuire 2016 and scan .bib files in link checker - #1629

Merged
henrydingliu merged 1 commit into
casact:mainfrom
Huyvux12:fix/1626-dead-paper-link-lychee-bib
Nov 15, 2026
Merged

henrydingliu merged 1 commit into
casact:mainfrom
Huyvux12:fix/1626-dead-paper-link-lychee-bib

Conversation

@Huyvux12

Copy link
Copy Markdown
Contributor

Fixes #1626

What was wrong

Two problems, one root cause each:

  1. Dead paper link — the taylor2016 entry (Taylor & McGuire, "Stochastic Loss Reserving Using Generalized Linear Models", CAS Monograph Additional chainladder functionality #3, 2016) in docs/library/references.bib pointed at a WPI-hosted PDF that no longer responds.
  2. The link checker never looked at the bibliography — .github/lychee.toml lists extensions = ["cff", "html", "ipynb", "md", "py", "rst", "toml", "yaml", "yml"] with no "bib", so lychee scanning the repo root never reads docs/library/references.bib. That is why the dead link went unnoticed (the scheduled check also only runs on the 1st of each month).

Changes (2 lines)

  • docs/library/references.bib: taylor2016 URL now points at the official CAS-hosted copy of the same monograph, https://www.casact.org/sites/default/files/database/monographs_papers_03-taylor.pdf.
  • .github/lychee.toml: added "bib" to extensions (kept alphabetical), so the bibliography is link-checked going forward.

No other URL was touched, and the monthly schedule was left unchanged.

Reproduction (base main @ 46727b1)

Before the fix:

$ curl -L "https://web.wpi.edu/Pubs/E-project/Available/E-project-042319-150245/unrestricted/03-Taylor.pdf"
curl: (52) Empty reply from server   # HTTP 000

After the fix, the replacement URL:

$ curl -L "https://www.casact.org/sites/default/files/database/monographs_papers_03-taylor.pdf"
HTTP 200, application/pdf, 4,144,349 bytes (PDF document, version 1.6)

Verification

  • references.bib still parses with bibtexparser: 15 entries before and after the change, taylor2016 URL is the new CAS link. Brace balance unchanged (194/194).
  • .github/lychee.toml parses as valid TOML; extensions now includes "bib".
  • Grepped the whole repo for web.wpi.edu / 03-Taylor: no other reference to the dead URL exists, so this entry was the only place to fix.
  • Lychee itself is not installed in this environment, so the checker-config change was verified by reading the config and the linkcheck.yml workflow (which runs lychee over the repo root with this config); the repo CI link check will exercise it on this PR.

Risks checked

  • The replacement is the same document (CAS Monograph No. 3) hosted by the publisher itself, not a third-party mirror, so it should be at least as stable as the original.
  • The linkcheck.yml job tolerates lychee exit code 2 (broken links found) by design, so this PR does not change CI failure behaviour — it only widens what gets scanned.

… CAS-hosted PDF; scan .bib files in link checker

- docs/library/references.bib: taylor2016 url now points at the
  CAS-hosted copy of Monograph casact#3 (the WPI URL returns an empty reply).
- .github/lychee.toml: add "bib" to extensions so lychee scans
  references.bib going forward; that is why the dead link was missed.
@github-actions

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 18.1% of exported symbols fully typed (301 / 1666)

Known Ambiguous Unknown Total
Project (head) 301 96 1269 1666

Other symbols referenced but not exported by chainladder: 24

Known Ambiguous Unknown Total
Other (head) 11 1 12 24

Symbols without documentation:

  • Functions without docstring: 330
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.94%. Comparing base (46727b1) to head (cd4a20e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1629   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          99       99           
  Lines        6427     6427           
  Branches      811      811           
=======================================
  Hits         6102     6102           
  Misses        207      207           
  Partials      118      118           
Flag Coverage Δ
unittests 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu merged commit f3f1803 into casact:main Nov 15, 2026
12 checks passed
@henrydingliu

Copy link
Copy Markdown
Member

@Huyvux12 thanks and welcome to the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dead paper link and potentially defective link checker

2 participants