Repository navigation
Fix #1626: replace dead WPI link for Taylor & McGuire 2016 and scan .bib files in link checker - #1629
Merged
henrydingliu merged 1 commit intoNov 15, 2026
Conversation
… CAS-hosted PDF; scan .bib files in link checker - docs/library/references.bib: taylor2016 url now points at the CAS-hosted copy of Monograph casact#3 (the WPI URL returns an empty reply). - .github/lychee.toml: add "bib" to extensions so lychee scans references.bib going forward; that is why the dead link was missed.
Huyvux12
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
November 15, 2026 21:13
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 99 99
Lines 6427 6427
Branches 811 811
=======================================
Hits 6102 6102
Misses 207 207
Partials 118 118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Nov 15, 2026
Member
|
@Huyvux12 thanks and welcome to the repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1626
What was wrong
Two problems, one root cause each:
taylor2016entry (Taylor & McGuire, "Stochastic Loss Reserving Using Generalized Linear Models", CAS Monograph Additional chainladder functionality #3, 2016) indocs/library/references.bibpointed at a WPI-hosted PDF that no longer responds..github/lychee.tomllistsextensions = ["cff", "html", "ipynb", "md", "py", "rst", "toml", "yaml", "yml"]with no"bib", so lychee scanning the repo root never readsdocs/library/references.bib. That is why the dead link went unnoticed (the scheduled check also only runs on the 1st of each month).Changes (2 lines)
docs/library/references.bib:taylor2016URL now points at the official CAS-hosted copy of the same monograph,https://www.casact.org/sites/default/files/database/monographs_papers_03-taylor.pdf..github/lychee.toml: added"bib"toextensions(kept alphabetical), so the bibliography is link-checked going forward.No other URL was touched, and the monthly schedule was left unchanged.
Reproduction (base
main@46727b1)Before the fix:
After the fix, the replacement URL:
Verification
references.bibstill parses with bibtexparser: 15 entries before and after the change,taylor2016URL is the new CAS link. Brace balance unchanged (194/194)..github/lychee.tomlparses as valid TOML;extensionsnow includes"bib".web.wpi.edu/03-Taylor: no other reference to the dead URL exists, so this entry was the only place to fix.linkcheck.ymlworkflow (which runs lychee over the repo root with this config); the repo CI link check will exercise it on this PR.Risks checked
linkcheck.ymljob tolerates lychee exit code 2 (broken links found) by design, so this PR does not change CI failure behaviour — it only widens what gets scanned.