Repository navigation
[DOCS] Show the link ratios in use in "Discarding Problematic Link Ratios" - #1638
Merged
Merged
Conversation
…tios" Each example in this section of the development tutorial now calls fit_transform on genins and shows age_to_age, which leaves the dropped link ratios blank, and then shows ldf_ in a new cell. Before, each example showed only ldf_, so a reader could not see which ratios a setting removed. One sentence in the section intro says what the two tables show. Closes casact#1631. Developed with an AI assistant (Árbol, running Muse).
scks1
requested review from
genedan,
henrydingliu and
kennethshsu
as code owners
November 16, 2026 21:13
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1638 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 100 100
Lines 6461 6461
Branches 820 820
=======================================
Hits 6138 6138
Misses 204 204
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
henrydingliu
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Each of the seven examples in the "Discarding Problematic Link Ratios" section of
docs/getting_started/tutorials/development-tutorial.ipynbnow runsfit_transform(genins)and showsage_to_age, then showsldf_in a new cell, as #1631 suggests. On the transformed triangleage_to_ageleaves the dropped link ratios blank, so a reader can see which ratios each setting removes. One new sentence in the section intro says what the two tables show.No code changes. The other cells of the notebook are unchanged.
Related GitHub Issue(s)
Closes #1631.
AI/LLM Usage
I drafted this change with Árbol, an AI assistant (running Muse). It ran the notebook against chainladder at main c113fd9 to fill in the new outputs. For each example it checked that
ldf_matches the output the tutorial showed before, and thatldf_equals the volume-weighted average of the link ratiosage_to_ageshows. I reviewed the change before opening the PR.Additional Context for Reviewers
The old outputs of the
drop_high=True, drop_low=True,drop_high=3anddrop_high=3, drop_low=2, preserve=2examples showed a "Some exclusions have been ignored" warning. On main these examples raise no warning, since 8165ca6 made that warning silent on a fully populated triangle such asgenins, so the new outputs have none. The docs build re-executes every notebook, so the stored outputs only affect how the notebook reads on GitHub.Submitter's Checklist
[FIX],[FEAT],[DOCS],[TST],[CHORE], or[BRK]).Reviewer's Checklist