Skip to content

[DOCS] Show the link ratios in use in "Discarding Problematic Link Ratios" - #1638

Merged
henrydingliu merged 1 commit into
casact:mainfrom
scks1:docs-1631-in-use-ratios
Nov 17, 2026
Merged

henrydingliu merged 1 commit into
casact:mainfrom
scks1:docs-1631-in-use-ratios

Conversation

@scks1

@scks1 scks1 commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Each of the seven examples in the "Discarding Problematic Link Ratios" section of docs/getting_started/tutorials/development-tutorial.ipynb now runs fit_transform(genins) and shows age_to_age, then shows ldf_ in a new cell, as #1631 suggests. On the transformed triangle age_to_age leaves the dropped link ratios blank, so a reader can see which ratios each setting removes. One new sentence in the section intro says what the two tables show.

No code changes. The other cells of the notebook are unchanged.

Related GitHub Issue(s)

Closes #1631.

AI/LLM Usage

I drafted this change with Árbol, an AI assistant (running Muse). It ran the notebook against chainladder at main c113fd9 to fill in the new outputs. For each example it checked that ldf_ matches the output the tutorial showed before, and that ldf_ equals the volume-weighted average of the link ratios age_to_age shows. I reviewed the change before opening the PR.

Additional Context for Reviewers

The old outputs of the drop_high=True, drop_low=True, drop_high=3 and drop_high=3, drop_low=2, preserve=2 examples showed a "Some exclusions have been ignored" warning. On main these examples raise no warning, since 8165ca6 made that warning silent on a fully populated triangle such as genins, so the new outputs have none. The docs build re-executes every notebook, so the stored outputs only affect how the notebook reads on GitHub.

Submitter's Checklist

  • I have reviewed and am adhering to the standards outlined in the project Governing Doc.
  • The PR subject title summarizes the changes, with one proper prefix ([FIX], [FEAT], [DOCS], [TST], [CHORE], or [BRK]).
  • I am a human (not a bot), and this PR form is written by a human.

Reviewer's Checklist

  • The implementation addresses the associated issue(s).
  • The implementation is appropriate, maintainable, and follows ARCHITECTURE.md.
  • PR subject title has the proper prefix and the subject is appropriate.
  • Relevant issue(s) are linked.
  • AI/LLM usage is disclosed and appropriate.
  • Documentation and tests are appropriate.
  • CI tests passed, or any failures are acceptable.
  • Leave a comment with the final recommendation (e.g. approve as is, request a secondary review, or flag an area for more review).

…tios"

Each example in this section of the development tutorial now calls
fit_transform on genins and shows age_to_age, which leaves the dropped
link ratios blank, and then shows ldf_ in a new cell. Before, each
example showed only ldf_, so a reader could not see which ratios a
setting removed. One sentence in the section intro says what the two
tables show.

Closes casact#1631.

Developed with an AI assistant (Árbol, running Muse).
@github-actions

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 18.1% of exported symbols fully typed (303 / 1674)

Known Ambiguous Unknown Total
Project (head) 303 96 1275 1674

Other symbols referenced but not exported by chainladder: 24

Known Ambiguous Unknown Total
Other (head) 11 1 12 24

Symbols without documentation:

  • Functions without docstring: 330
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (c113fd9) to head (a5d556c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1638   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         100      100           
  Lines        6461     6461           
  Branches      820      820           
=======================================
  Hits         6138     6138           
  Misses        204      204           
  Partials      119      119           
Flag Coverage Δ
unittests 95.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu
henrydingliu merged commit e82cb4d into casact:main Nov 17, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] Add in-use link ratios to "Discarding Problematic Link Ratios"

2 participants