Repository navigation
Conversation
9805b01 to
2d1a055
Compare
78bf017 to
5a0d455
Compare
| $url->param('perpage', $formdata->perpage); | ||
| } | ||
|
|
||
| redirect($url); |
There was a problem hiding this comment.
redirect should not be needed?
There was a problem hiding this comment.
tell the form to use get rather than post
optionally - remove other junk from the url which isn't needed (eg sesskey)
There was a problem hiding this comment.
The page has been refactored. It all works, but immediately after submitting the form you do get a page with all the URL param guts exposed.
| $string['field_component'] = 'Component'; | ||
| $string['field_components'] = 'Components'; | ||
| $string['field_components_help'] = 'Restrict the search to these components. Separate components with commas. eg core_h5p,mod_hvp,mod_assign'; | ||
| $string['field_course_id'] = 'ID (course)'; |
There was a problem hiding this comment.
Course ID - or reuse string from core?
There was a problem hiding this comment.
pretty sure we can remove this
There was a problem hiding this comment.
but its still in the diff?
| $string['field_tables'] = 'Tables'; | ||
| $string['field_tables_help'] = 'Tables and columns to search. Separate multiple tables/columns with a comma. If not specified, search all tables and columns. Example format: <code>user,assign_submission:submission</code>'; | ||
| $string['field_timeend'] = 'End'; | ||
| $string['field_timemodified'] = 'Modified'; |
There was a problem hiding this comment.
maybe also in core?
There was a problem hiding this comment.
also still in the diff
| $rownum = 0; | ||
|
|
||
| while (($row = fgetcsv($fp, 0, ',', '"', '\\')) !== false) { | ||
| $timemodified = $row[$timemodifiedindex]; |
There was a problem hiding this comment.
lets keep this, but the srarch filtering I want was back a step in the original search form and this needs to be passed into the task as custom data, and so the csv will be a subset of dates already
Further filtering the csv by date is also useful so lets keep this
# Conflicts: # lang/en/tool_advancedreplace.php
Also rename filter form.
472d3fb to
e3c221a
Compare
daa9045 to
6c69f2e
Compare
6c69f2e to
dda2dac
Compare
|
Support any table with a timemodified, or a lastmodified. |
| // Clearing the filter is a plain link back to the unfiltered report. | ||
| $customdata['clearurl'] = $url; | ||
|
|
||
| $form = new results_filter_form($url, $customdata, 'get'); |
There was a problem hiding this comment.
See if you can get the sesskey removed.
Read table definitions and form acache to store the names of the fields that store last modified timestamps. Use this cache during filtering. Add help icon to explain time modified. Add unit test.
01e1880 to
2364c44
Compare
resolves #153
No bonus points.