Repository navigation
Conversation
omercier
marked this pull request as ready for review
October 27, 2026 08:50
omercier
requested review from
Evan-Adam and
lucie-tirand
and removed request for
a team
October 27, 2026 08:50
**Behavior changes**
- `qos`: the `traffic-in`/`traffic-out` counters (and the `*-prct` ones derived from them) now report an actual
rate in b/s. They previously reported the cumulative SNMP counter (×8) as if it were a rate, so the values
displayed and graphed will drop to their real level after the upgrade.
- `qos`, `vpn-status`: the cache file name now uses SHA-256 instead of MD5. The first check after the upgrade
rebuilds the cache, so traffic rates show "Buffer creation" once.
- `ha-nodes`: metrics are renamed to the current naming scheme. Graphs based on the old names will be split.
- `dead_nodes` → `ha.dead_nodes.count` (same name as in the `ha-cluster` mode)
- `health_<serial>` → `<serial>#ha.node.health.percentage`
Threshold options are unchanged (`--warning-dead-nodes`, `--warning-health`, ...).
- `uptime`: the output uses the standard duration format:
`Uptime: 71 days 20 hours 39 minutes 47 seconds` → `Uptime: 71d 20h 39m 47s`.
**New options** (the former `--filter-*` options keep working as deprecated aliases of `--include-*`)
- `ha-nodes`: `--include-node`, `--exclude-node` (deprecates `--filter-node`)
- `health`: `--include-serial`, `--exclude-serial` (deprecates `--filter-serial`)
- `qos`: `--include-name`, `--exclude-name` (deprecates `--filter-name`)
- `vpn-status`: `--include-id`, `--exclude-id`, `--include-src-ip`, `--exclude-src-ip`, `--include-dst-ip`,
`--exclude-dst-ip` (deprecates `--filter-id`, `--filter-src-ip`, `--filter-dst-ip`)
**Fixes**
- `health`: services with no value are now skipped as intended instead of being evaluated.
- `hardware`: a disk with no name now falls back to its instance label instead of an empty name.
- `vpn-status`: the help now lists the actual status variables (`%{ipSrc}`, `%{ipDst}` instead of
`%{srcIp}`, `%{dstIp}`).
**Documentation**
- `qos`, `vpn-status`: each threshold option is now documented individually instead of `--warning-*`/`--critical-*`.
omercier
force-pushed
the
CTOR-2498-Pack-network-stormshield-snmp-add-new-interface-discovery
branch
from
November 2, 2026 13:58
3fb3a45 to
01f2a61
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various enhancements suggested by Stormshield vendor themselves.
Refs: CTOR-2498
Type of change
How this pull request can be tested ?
Almost everything comes with robot tests.
Long description for patient readers
Behavior changes
qos: thetraffic-in/traffic-outcounters (and the*-prctones derived from them) now report an actualrate in b/s. They previously reported the cumulative SNMP counter (×8) as if it were a rate, so the values
displayed and graphed will drop to their real level after the upgrade.
qos,vpn-status: the cache file name now uses SHA-256 instead of MD5. The first check after the upgraderebuilds the cache, so traffic rates show "Buffer creation" once.
ha-nodes: metrics are renamed to the current naming scheme. Graphs based on the old names will be split.dead_nodes→ha.dead_nodes.count(same name as in theha-clustermode)health_<serial>→<serial>#ha.node.health.percentageThreshold options are unchanged (
--warning-dead-nodes,--warning-health, ...).uptime: the output uses the standard duration format:Uptime: 71 days 20 hours 39 minutes 47 seconds→Uptime: 71d 20h 39m 47s.New options (the former
--filter-*options keep working as deprecated aliases of--include-*)ha-nodes:--include-node,--exclude-node(deprecates--filter-node)health:--include-serial,--exclude-serial(deprecates--filter-serial)qos:--include-name,--exclude-name(deprecates--filter-name)vpn-status:--include-id,--exclude-id,--include-src-ip,--exclude-src-ip,--include-dst-ip,--exclude-dst-ip(deprecates--filter-id,--filter-src-ip,--filter-dst-ip)Fixes
health: services with no value are now skipped as intended instead of being evaluated.hardware: a disk with no name now falls back to its instance label instead of an empty name.vpn-status: the help now lists the actual status variables (%{ipSrc},%{ipDst}instead of%{srcIp},%{dstIp}).Documentation
qos,vpn-status: each threshold option is now documented individually instead of--warning-*/--critical-*.