Repository navigation
Async IDC: rust outbox macro - #6376
Open
Shubham8287 wants to merge 12 commits into
Open
Shubham8287 wants to merge 12 commits into
Shubham8287 wants to merge 12 commits into
Conversation
Shubham8287
force-pushed
the
shub/idc-receiver-bindings-split
branch
from
October 27, 2026 14:54
1469023 to
4dc0fa6
Compare
Shubham8287
force-pushed
the
shub/idc-rust-outbox-macro-split
branch
from
October 27, 2026 14:55
e657762 to
9d87560
Compare
Comment on lines
+440
to
+449
| fn delete(&self, row: Self::Row) -> bool { | ||
| fn delete(&self, row: Self::Row) -> bool | ||
| where | ||
| Self: MutableTable, | ||
| { |
Collaborator
There was a problem hiding this comment.
Is this a breaking change? Table is technically part of the public api.
Contributor
Author
There was a problem hiding this comment.
You mean, If someone were doing:
fn do_something<T: spacetimedb::Table>(table: &T) {
table.clear();
}that would break?
Collaborator
There was a problem hiding this comment.
I believe so, yes.
Contributor
Author
There was a problem hiding this comment.
yeah, I overlooked Table trait to be as public api itself, only cared to not break methods.
I fixed this by adding struct OutboxTable<T: Table> wrapper type around Table.
Comment on lines
+457
to
+469
| fn clear(&self) -> u64 { | ||
| fn clear(&self) -> u64 | ||
| where | ||
| Self: MutableTable, | ||
| { |
Shubham8287
force-pushed
the
shub/idc-rust-outbox-macro-split
branch
from
October 28, 2026 11:34
2a2be07 to
64a3a96
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Macro side changes taken out from: #6001.
Based on #6375
Adds Rust outbox declarations for intermodule reducer calls using generated receiver bindings.
It can be reviewed through commits:
#[param(name = ...)], with compile-time type checking.API and ABI breaking changes
Additive module API. Update and delete APIs are unavailable on outbox tables.
No host ABI changes.
Rollback safety impact
N/A.
Expected complexity level and risk
Proposal drift
The
outbox!convenience macro is not implemented yet.Source-based local reducer references and self-referential outboxes are handled in a separate PR.
Testing