Repository navigation
Add system table for cache policies and enable local disk paging - #6443
Open
joshua-spacetime wants to merge 3 commits into
Open
joshua-spacetime wants to merge 3 commits into
joshua-spacetime wants to merge 3 commits into
Conversation
joshua-spacetime
force-pushed
the
joshua/cache-policies
branch
from
October 31, 2026 00:08
4cbb0f1 to
afe16a9
Compare
joshua-spacetime
force-pushed
the
joshua/cache-policies
branch
from
October 31, 2026 00:14
afe16a9 to
a9c3b87
Compare
kim
reviewed
Nov 2, 2026
| /// Allow tables to evict pages according to their cache policy. | ||
| pub evict_pages: bool, | ||
| /// Allow blob eviction. Disable this when tables need their blobs to stay in | ||
| /// memory: blobs can be shared, and their references do not track table policies. |
Contributor
There was a problem hiding this comment.
How about this: we make ResidentObjects::reserve_blob take an eviction policy, derived from the policy of the blob's insertion table, and store it in the BlobFrame directly.
| pub local_store: BackingStore, | ||
| pub remote_store: Option<BackingStore>, | ||
| /// Allow tables to evict pages according to their cache policy. | ||
| pub evict_pages: bool, |
Contributor
There was a problem hiding this comment.
It's a bit unclear what this is for.
In particular, the combination evict_pages: true, evict_blobs: false does not seem useful, except maybe for testing.
Collaborator
Author
There was a problem hiding this comment.
This is just here because I wanted to keep the scope of this change small and so I punted on blob eviction.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add
st_table_cache_policyto persist each table’s caching policy and enable the local disk paging implemented in #6352. Tables default to remaining in memory, preserving existing behavior. Changes include:st_table_cache_policyto store each table’s policy. Tables without an entry default to remaining in memory.API and ABI breaking changes
N/A
Rollback safety impact
N/A
Expected complexity level and risk
3
Testing
TODO