Repository navigation
engine: retain dirty markers for stacked release mounts - #406
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a guest stacks another filesystem at a managed writable mount path, release can unmount only the upper layer and incorrectly report the data disk as clean.
Exclude the selected mountinfo record by index, then treat any remaining record at the same path or on the same device as unclean. This preserves the dirty marker without adding guest calls or changing teardown. Three cases in the existing test table cover both mountinfo listing orders and a stacked whole-device bind with identical parsed fields.
Validation: static review of the engine-to-pool marker path and
git diff --check. Tests, lint, builds, CI, and runtime checks were not run, as requested.LOC: production +1/-1; tests +3/-0.