Repository navigation
Fix and ready for review: /schools embeds src="/map" but no route exi… - #3683
Merged
Merged
Conversation
Large imported photos were blowing out the first viewport with a fixed 520px desktop height. Co-authored-by: Cursor <cursoragent@cursor.com>
- Creation paths that skip EventsQuery::store() (imports set '', Nova) hit this
- - Change: 5 lines in approve()
- if empty, set cw{yy}-{5 random alnum} in same update() call before mail is queued
- Matches pattern used by support tool /^cw\d{2}-[A-Za-z0-9]+$/
- - Test: added to tests/Feature/ApproveEventTest.php, asserts generated code + code present in rendered mail
- Found the likely root cause - Applying the fix: Yes - it's a real bug affecting every new user, not just the person who wrote in - which is exactly the "I registered, now I can't log in" pattern people report - What changed (worktree bernd/edit-202610151022, nothing committed):
- the blade view resources/views/map/index.blade.php and Livewire App\Livewire\MapWire were orphaned - One line added to routes/web.php, next to the existing leaflet route: Verified locally: php artisan route:l… - map, and serving the app gave mapstatus=200 plus schoolsstatus=200 (route resolves, view renders) - Not yet committed - php artisan test did not run: the shell has no timeout binary, so the command aborted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan