Repository navigation
Release v0.1.0-beta.2 - #44
Conversation
_Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I33025b77f36fe1aa07caf6d235625e3179ece212 Signed-off-by: Thomas Kosiewski <tk@coder.com>
Communique 1.0.3 defaults to 4096 tokens per response. Generating the v0.1.0-beta.2 notes failed twice with "submit_release_notes was malformed 3 times". Communique 1.2.2 raised its own default to 16384 for this failure. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Ib949fba4b692fbf9280e4c52b39e5c4da3b8ce6c Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
FAIL Independent pre-merge verification of release PR #44 (
Wrong CHANGELOG claim (blocker)Under
Fix: delete that - `TerminalSnapshot.cursorVisible: boolean` reflects DECTCEM state (`ESC[?25h` / `ESC[?25l`). The field is required, so code that constructs its own `TerminalSnapshot` objects must set it ([#17](https://github.com/coder/libghostty-vt-node/pull/17), [#38](https://github.com/coder/libghostty-vt-node/pull/38)).Notes (not blockers)
Generated with |
Communique writes "## [v0.1.0-beta.2](url) - date". The entry check required whitespace after "]", so it never saw an existing entry and every push to a release branch regenerated the notes over hand edits. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Ia23261661b60dcf63f73914409e025a5d57b80b3 Signed-off-by: Thomas Kosiewski <tk@coder.com>
cursorVisible first ships in this release, so it was never optional in a published version. The #39 bullet only changed a test. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: I9407e114ee961f9392f37b4afecafe2a774a0c4c Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
FAIL Independent pre-merge verification of release PR #44 (
False CHANGELOG claims (blocker)These two
Fix: delete both bullets above, and replace the - `encodeMouse(event, options)` on every terminal, backed by Ghostty's mouse-protocol encoder with validation of grid geometry, surface coordinates, and pressed-button state. It reads each caller field once, so the value it validates is the value it encodes. In UTF-8 mouse mode (1005), rows whose encoded value is above U+FFFF encode as 4-byte UTF-8, and cells whose encoded value would be a Unicode surrogate throw a `RangeError`. A new `supportsMouseInput` capability marker lets consumers probe at import time ([#12](https://github.com/coder/libghostty-vt-node/pull/12), [#41](https://github.com/coder/libghostty-vt-node/pull/41), [#42](https://github.com/coder/libghostty-vt-node/pull/42)).Source for each added sentence: #41 destructures every caller field once in The Bullets I checked and found true
Notes (not blockers)
Generated with |
encodeMouse first ships in this release, so #41 and #42 did not fix a released bug. Their behavior now reads as part of the new API. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Change-Id: Ic6de3b1b21ac87d8274619c74fd8121ef0e333e0 Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
PASS+NOTES Independent pre-merge check of the release PR #44 CHANGELOG at the new head. I did not write this text. All 10 bullets in the
Check 1. Diff scopePass. Check 2. Each bulletBeta.1 baseline: Added
Changed
Fixed
Security
The Fixed section no longer has an Check 3. Links and PR numbersPass. The entry has 13 PR links. For every link, the No correction text is needed. Notes (not blockers for the CHANGELOG)
Generated with |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Why
Ship the changes merged since
0.1.0-beta.1to npm. They include mode-aware mouse encoding (#12), the new snapshot attributes andcursorVisible(#17, #38), and Ghosttyv1.4.0with DECSTR support (#43).What changed
package.jsonandpackage-lock.jsongo from0.1.0-beta.1to0.1.0-beta.2. The branch name matches the version, sopublish.ymlcreatesv0.1.0-beta.2after merge.release-changelogworkflow adds the CHANGELOG entry to this branch.communique.tomlraisesmax_tokensto 16384. With Communique 1.0.3's default of 4096, generating these notes failed twice with "submit_release_notes was malformed 3 times". The next run succeeded.prepare-release-changelog.mjsnow detects Communique's## [vX](url) - dateheading. Before, every push regenerated the entry over hand edits.cursorVisibleandencodeMousefirst ship in this release, so they are listed as Added, not as changes or fixes.Blast Radius
The merge publishes
0.1.0-beta.2to npm under thebetadist-tag.lateststays on0.1.0-beta.0. Consumers that build aTerminalSnapshotthemselves must now setcursorVisible(#38).Verification
RELEASE_BRANCH_NAME=release/v0.1.0-beta.2 node .github/scripts/prepare-release-changelog.mjs origin/mainprintsshould_generate=trueandtag_name=v0.1.0-beta.2.resolve-npm-publish-tag.mjsprintsbeta.npm run typecheckandnpm test(73 passed).v0.1.0-beta.1tag and confirm that the packed tarball loads its addon fromprebuilds/.mise run release-prebuildspass:build:libghostty,build,build:prebuild,verify:prebuildsandnpm pack --dry-run.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high