Repository navigation
fix: flat-file index and settings cache fixes for 4.1.1 - #625
Open
TallblokeUK wants to merge 3 commits into
Open
TallblokeUK wants to merge 3 commits into
TallblokeUK wants to merge 3 commits into
Conversation
sheabunge
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
condition_idkey load with no condition. This removes theUndefined array key "condition_id"warning on sites with an index written by an earlier version.Handler_Registry::get_handlers().Testing
Snippet_Files_Test(index rebuild, entry withoutcondition_id) andSettings_Test(checkbox read back after save). All three fail on 4.1.0 and pass with these changes.npm run lint:php: no findings.chromium-file-based-snippets: 218 passed, 7 skipped.