Repository navigation
fix: stop an unreadable changelog date from breaking admin pages - #626
Open
TallblokeUK wants to merge 2 commits into
Open
TallblokeUK wants to merge 2 commits into
TallblokeUK wants to merge 2 commits into
Conversation
…nvolving the filesystem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Welcome_Clientparses changelog release dates and remote welcome data dates withdate_create_immutable()instead ofnew DateTimeImmutable()in atry/catch ( Exception ). A value that is not a date no longer throws, and a changelog heading without a date (for example(UPCOMING)) is shown with its label as before.Testing
Welcome_Client_Test: a changelog with an(UPCOMING)heading is read with the label kept as the date.