Skip to content

fix: stop an unreadable changelog date from breaking admin pages - #626

Open
TallblokeUK wants to merge 2 commits into
corefrom
hotfix/changelog-date/core
Open

TallblokeUK wants to merge 2 commits into
corefrom
hotfix/changelog-date/core

Conversation

@TallblokeUK

Copy link
Copy Markdown
Contributor

Changes

  • Welcome_Client parses changelog release dates and remote welcome data dates with date_create_immutable() instead of new DateTimeImmutable() in a try/catch ( Exception ). A value that is not a date no longer throws, and a changelog heading without a date (for example (UPCOMING)) is shown with its label as before.

Testing

  • New PHPUnit test Welcome_Client_Test: a changelog with an (UPCOMING) heading is read with the label kept as the date.
  • PHPUnit full suite: 502 tests, OK (43 skipped).
  • PHPCS: no findings on the changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants