Repository navigation
fix: read the pressed submit button from the submit event - #633
Open
Toraastrta wants to merge 1 commit into
Open
Toraastrta wants to merge 1 commit into
Toraastrta wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #606.
The editor worked out which submit button was pressed from
document.activeElement. Safari, and Firefox on macOS, do not focus a button when it is clicked, so focus stays in the code editor or the title field and no action matches. Save and Activate then saves the snippet without activating it, and Save and Deactivate leaves it active.Changes
SnippetForm.tsx: the submit action is read from the submit event'ssubmitterinstead of the focused element.Verification
tests/e2e/editor-submit-actions.spec.ts. The clicks keep focus where it was, as Safari does, by cancelling the button'smousedown.core-beta(saved inactive).core-beta(stays active).core-betaand fails if the Enter check is removed from the fix.code-snippets-edit.spec.tsandeditor-save-outcomes.spec.tspass in both thechromium-db-snippetsandchromium-file-based-snippetsprojects (28 tests).tsc --noEmitreports no errors in them.I used Claude Code to write the fix and the tests. I reviewed the change and ran the checks above myself.