Repository navigation
chore(deps): update SDK dependencies and clean implementation installs - #572
Charles Hudson (phobetron) merged 1 commit into
Conversation
Code Review Agent Run #56d989Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
6fa2fea to
b2701b2
Compare
Impact Analysis by BitoCross-Repository Impact Analysis
Code Paths AnalyzedImpact: Flow: Direct Changes (Diff Files): Repository Impact: Cross-Repository Dependencies: Database/Caching Impact: API Contract Violations: Infrastructure Dependencies: Additional Insights: Testing RecommendationsFrontend Impact: Service Integration: Data Serialization: Privacy Compliance: Backward Compatibility: OAuth Functionality: Cross-Service Communication: Reliability Testing: Additional Insights: Analysis based on known dependency patterns and edges. Actual impact may vary. |
✅ Review Settings OverriddenStatus: Guidelines:
Note: Extra guidelines beyond 3 general purpose guidelines and 1 language specific guideline per language are not processed. Guidelines are fetched from the source branch. |
Code Review Agent Run #ff9b58Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
b2701b2 to
30c84c6
Compare
Code Review Agent Run #1bc7dcActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Summary
Newer es-toolkit merge types expose a widened
stringin the React Native SDK's default event-builder configuration, causing typecheck and declaration-build failures. Give those defaults the existing publicEventBuilderConfigtype before merging them. This preserves the closed channel union and existing runtime behavior without casts oras const.Update the workspace catalog and applicable implementation manifests to the newest stable releases published more than 24 hours before selection:
Playwright is updated in the shared browser-test catalog and both standalone Node implementations. Regenerate the root lockfile; pnpm also consolidates existing compatible resolutions of jiti, @types/node, and @babel/runtime. Node remains 26.12.1 in both
.nvmrcand the workspace configuration.Implementation installation
Make
implementation:installremove the target implementation'snode_modulesbefore installing. When the implementation declares Next.js, also remove.nextso compiled output cannot retain the previous SDK. Cleanup runs after local tarball preparation succeeds, applies only to the selected implementation, and preserves.envand source files.Document the cleanup and the requirement to run
pnpm build:pkgsafter SDK source changes inCONTRIBUTING.md.Validation
pnpm build:pkgs, aggregatepnpm size:report, andpnpm size:checkpassed with existing budgets.node_modulesand.next, preserves the existing.envhash, and installs matching App Router SDK artifacts. The helper passed lint and TypeScript checks.variant-resolution.spec.tspassed all 27 tests across Chromium, Firefox, and WebKit. Other Web and native E2E suites were not run.Compatibility note
Rstest 0.12.0 declares a happy-dom peer range of
^20.8.3; the newest Rstest release eligible under the same 24-hour cutoff still excludes happy-dom 21. The peer warning remains visible. The three affected browser SDK test suites passed against happy-dom 21.0.4; no peer override or warning suppression was added.