Skip to content

have less characters in the hub test socket name - #4785

Merged
sabban merged 2 commits into
masterfrom
fix/hub/tests
Oct 28, 2026
Merged

sabban merged 2 commits into
masterfrom
fix/hub/tests

Conversation

@sabban

@sabban sabban commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Clone the hub into /hub instead of ./hub in the bats-hub workflow, so the paths hubtest creates stay short.
hubtest puts the LAPI unix socket under /.tests//runtime/, and with the old clone path aws-cis-benchmark-security-group-change hit 108 characters, over Linux's 107 limit and made the test failed.

Fixes #

How it was tested

The point is to make the CI work.

Checklist

  • One concern only.
  • No break to LAPI/CAPI payloads, database schema, config keys, or cscli -o json|raw output.
  • A human has reviewed this diff line by line.
  • A human has tested this change, not only an agent.

AI assistance used:

@github-actions

Copy link
Copy Markdown

@sabban: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions

Copy link
Copy Markdown

@sabban: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@sabban

sabban commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

/kind fix
/area cscli

@codecov

codecov Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.81%. Comparing base (3d369d6) to head (b2cd4f1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4785      +/-   ##
==========================================
- Coverage   71.83%   71.81%   -0.02%     
==========================================
  Files         545      545              
  Lines       37163    37163              
==========================================
- Hits        26695    26690       -5     
- Misses      10467    10472       +5     
  Partials        1        1              
Flag Coverage Δ
bats 45.24% <ø> (-0.03%) ⬇️
unit-linux 49.77% <ø> (-0.02%) ⬇️
unit-windows 37.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sabban
sabban merged commit f4b4d9d into master Oct 28, 2026
17 checks passed
@sabban
sabban deleted the fix/hub/tests branch October 28, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants