Repository navigation
ja: drop the stray row/column word from matrix sizes and verify matrix strings - #964
Merged
Merged
Conversation
…x strings
A one-row matrix was "1 かける 2 行 行列" and a one-column matrix "3 かける 1
列 行列", with 行 ("row") or 列 ("column") placed before 行列 word for word
from English. The size already says it is one row or one column, and 行
standing alone is read クダリ or アルキ by Open JTalk, so the extra word is
gone: "1 かける 2 行列", "3 かける 1 ベクトル". The end marker of a scalar
determinant is 行列式終了, like 行列終了 and ベクトル終了, instead of 末端の
行列式 ("the terminal determinant"). The other matrix, determinant and norm
strings are unchanged and marked verified.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PxieePkAy46rhaYhV8EKRR
With ClearSpeak_Matrix set to EndVector, a column of four or more rows
started "4 かける 1 ベクトル" but ended with 行列終了. The short column
and both row rules already end with ベクトル終了 there, so this one does
too. The English rule has the same gap ("end matrix"), so the rule
carries an audit-ignore note. Tests cover EndMatrix and EndVector for
the long row and column forms.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PxieePkAy46rhaYhV8EKRR
Linux library size: 0.59 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This marks the matrix strings in the Japanese rules as verified and fixes two readings. A one-row matrix was "1 かける 2 行 行列" and a one-column one "3 かける 1 列 ベクトル", with the English "row"/"column" placed before 行列; the size already says that, and a lone 行 after a space is read クダリ or アルキ by Open JTalk, so it is now "1 かける 2 行列" and "3 かける 1 ベクトル". The end marker of a scalar determinant, 末端の 行列式 ("the terminal determinant"), is now 行列式終了 like 行列終了 and ベクトル終了, and a long column read with EndVector now ends with ベクトル終了 instead of 行列終了 (en has the same gap, so that rule has an audit-ignore note). Everything else in the matrix, determinant and norm rules (general.yaml, linear-algebra.yaml and the overview matrix rule) keeps its wording and goes from t: to T:. All language tests pass, also merged with #962, and audit-translations ja goes from 3212 to 3183 untranslated strings with rule differences still at 30.