Repository navigation
Split quoted attributes without the lookahead regex - #252
Merged
Merged
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
quoted_semicolon_patternsregexes split on a separator only if the rest of the string has balanced quotes. That lookahead rescans the remaining text at every separator, so parsing is quadratic in the attribute length. It gets slow for GTF records with many attributes or quoted values that contain semicolons.This replaces the regex with
_split_on_unquoted_separator, which splits naively and then rejoins pieces until the number of quotes to the right is even. That's the same condition the lookahead checks, including for unbalanced quotes, but each piece is scanned once.Rough timings on synthetic files: