Repository navigation
fix(ci): gate release on every check in one test-build-release pipeline - #162
Merged
Merged
Conversation
Release (publish.yml), the golden suite and sync-skills ran as three workflows on the same push with no needs: edge, so semantic-release could tag and publish to npm while a gate was red or still running. Only its own skill-health job gated it; compliance, validate-doctrine and skill-verify ran two or three times. - test-build-release.yml: sync, verification-gates, skill-verify and story-verify run in parallel; release needs: all four and runs only on push to main. PR runs cancel stale runs; pushes queue and release never cancels in progress. Replaces publish.yml, sync-skills.yml and golden-suite.yml. - Portfolio template (danielvm-git/.github): ubuntu-22.04 and SHA-pinned actions (checkout v7.0.0, setup-node v6.4.0, upload-artifact v7.0.1, pages v5/v6), also in docs-site, publish-wiki and sync-references. Agent workflows stay as-is per migration plan v2. - test-ci-pipeline-contract.sh (golden gate + self-test) asserts the shape: release needs every gate, push-to-main only, no ubuntu-latest, SHA pins, timeouts, non-cancelling release and Pages, retired workflows gone. - Docs and gate-trace skill point at the new pipeline; the traceability reference no longer claims CI runs check-blind-spots.sh. Refs: BUG-2026-10-25-release-not-gated
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
## [2.88.14](v2.88.13...v2.88.14) (2026-10-25) ### Bug Fixes * **ci:** gate release on every check in one test-build-release pipeline ([#162](#162)) ([14250d8](14250d8))
|
🎉 This PR is included in version 2.88.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release(publish.yml),Golden Anti-Vacuity SuiteandSync Skills on Pushran as three workflows on the same push with noneeds:edge. semantic-release could tag and publish to npm while a gate was red or still running — only its ownskill-healthjob gated it. Bug file:specs/bugs/BUG-2026-10-25-release-not-gated.md. Follows #161 (speed) with the structural fix from the portfolio template (danielvm-git/.github)..github/workflows/test-build-release.yml:sync,verification-gates,skill-verify,story-verifyrun in parallel;releaseneeds:all four and runs only on push tomain. Replacespublish.yml,sync-skills.yml,golden-suite.yml. Job names are unchanged; the ruleset requires no status checks, so nothing else needs updating.validate-doctrineandrun-skill-verify.sheach run once (were up to 3×).releasenever cancels in progress.ubuntu-22.04and SHA-pinned actions (checkout v7.0.0, setup-node v6.4.0, upload-artifact v7.0.1, configure-pages v6.0.0, upload/deploy-pages v5.0.0) here and indocs-site,publish-wiki,sync-references. SHAs resolved from each tag via the GitHub API. Agent workflows (agent-locks.yml, generatedagentics-maintenance.yml) stay as-is per migration plan v2.scripts/test-ci-pipeline-contract.sh(+--self-test) in the golden suite asserts the shape so it cannot drift back.check-blind-spots.sh(it never did).Not in scope: Pages deploy still runs as its own workflow (
docs-site.yml), not gated on the pipeline.Test plan
OKafter; self-test proves each rule fails on its own breach (bash 5 and macOS bash 3.2)actionlintclean on all changed workflows--strictreleaseskippedmainrun after merge:releasestarts only after all four gate jobs finish, and publishes the next version🤖 Generated with Claude Code