Repository navigation
fix(ci): gate the GitHub Pages deploy on every check in test-build-release - #164
Merged
Merged
Conversation
…lease docs-site.yml ran as its own workflow on docs pushes, in parallel with the pipeline, so Pages could publish while a gate job was red. Move the build and deploy into test-build-release.yml as pages-build (needs all four gate jobs, push/dispatch on main, dorny/paths-filter keeps the old docs paths) and pages-deploy (concurrency pages, no cancel, 3-attempt retry). The pipeline contract now requires every actions/deploy-pages job to live in the pipeline, need every gate transitively, be limited to main, avoid always()/cancelled() and never cancel in progress; self-test fixtures cover each breach. Refs: BUG-2026-10-25-pages-not-gated
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 25, 2026
## [2.88.15](v2.88.14...v2.88.15) (2026-10-25) ### Bug Fixes * **ci:** gate the GitHub Pages deploy on every check in test-build-release ([#164](#164)) ([5f3e4de](5f3e4de))
|
🎉 This PR is included in version 2.88.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docs-site.ymlran as its own workflow on docs pushes, in parallel withTest Build Release. With noneeds:edge, Pages could publish whilesync,verification-gates,skill-verifyorstory-verifywas red or still running. Last gap from the portfolio template (danielvm-git/.github,docs/concept/github-actions-best-practices.md). Bug:specs/bugs/BUG-2026-10-25-pages-not-gated.md.Fix
test-build-release.ymlgets two new jobs:pages-build: needs all four gate jobs; runs only on push or dispatch onmain.dorny/paths-filter(SHA-pinned, v4.0.3) keeps the old docs paths, so a push that touches no docs input skips the build. A manual dispatch always redeploys.pages-deploy: needspages-build;concurrency: pages,cancel-in-progress: false; the same 3-attempt deploy retry.ubuntu-22.04, SHA-pinned actions and timeouts. Onlypages-deploygetspages: write/id-token: write.docs-site.ymlis removed.scripts/test-ci-pipeline-contract.sh: everyactions/deploy-pagesjob must live in the pipeline, need every gate job (directly or through another job), be limited tomain, not usealways()/cancelled(), and never cancel in progress. New--self-testfixtures cover each of these breaches.Evidence
FAIL: pipeline has no Pages deploy jobandFAIL: docs-site.yml:deploy: Pages deploy outside the pipeline. After:OK. Self-test passes 11/11 on bash 5 and on macOS/bin/bash3.2, and I checked that each fixture fails for its own reason.actionlintreports no problems.trace-stories --strict.After merge
A docs change on
mainshould startpages-buildonly after all four gate jobs finish. That run gets recorded in the bug file.