Repository navigation
feat: skip the Jev round-trip when trimming can only reproduce the tools array - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #9.
routePayloadnow returns the silent passthrough beforeaskJevwhen there is no candidate function tool, or when the lone candidate is the only entry inpayload.tools— every Jev outcome (trim / bypass) hands the big model the identical request, so the round-trip is pure added latency (up totimeoutMs, default 2 s).Correction to the issue's proposed fix
Issue #9 proposed guarding on
names.length < 2. Verified against the trim implementation (src/index.ts): the filter keeps only entries matching the chosen name, so a Responses-API payload like[{type:web_search}, {type:function, function:{name:shell}}]has exactly one candidate but a successful trim drops the built-in — a real, tested behavior (test 7). The literal guard would have regressed it. Shipped guard instead fires only when the trim is provably a no-op: