Repository navigation
feat: log note line when the tool list exceeds the criteria cap - #25
Merged
Merged
Conversation
askJev silently dropped every tool past the 254th from the criteria, so a 260-tool request offered 254 to routing with zero operator signal. Behavior stays safe (a pick among kept tools still trims); the note is awareness only. The JEV_MODEL env-only doc claim from the same issue was already fixed by #24. - askJev: one "note:" line before the round-trip when names.length > 254 - DEVELOPMENT.md: table row for the note: line (can precede apply: too) - Test 23: 260-tool payload — stub criteria = 254 tools + respond_to_user, note logged, trim still applies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #11 (claim 1 only — see below).
askJevcapped offered criteria atnames.slice(0, MAX_CRITERIA - 1): past 254function tools the excess was silently invisible to routing. Behavior was safe
(a pick among kept tools still trims), but the operator had no signal. Now one
note:line is logged before the round-trip:[jev] note: 260 tools exceed criteria cap 254 — first 254 offered to jevnote:is a new tag (neverapply:/bypass:-replacing); documented inDEVELOPMENT.md's error/context-lines table.
respond_to_user,note:line in JEV_DEBUG_FILE, trim still applies.Issue claim 2 (
JEV_MODELdocs) was already fixed by 038195f (#24), whichlanded two days after the issue was opened — verified: the "env-only extras"
sentence no longer exists in any doc; code (file-wins) unchanged, per the issue.
npm run typecheck && npm test && npm run build— all green (25/25).Fixes #11