Skip to content

Validate manifest references and upstream build arguments - #487

Merged
3alpha merged 1 commit into
masterfrom
fix/manifest-spec-validation
Nov 12, 2026
Merged

3alpha merged 1 commit into
masterfrom
fix/manifest-spec-validation

Conversation

@3alpha

@3alpha 3alpha commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

A package currently passes SPEC-M05 if one service matches the declared upstream version, even when another service uses a different value. Explicit manifest service references and unsupported global-env names can also survive build-time checks and fail or silently do nothing at installation.

Check every matching build argument, accept digest suffixes only with a complete SHA-256 hash, and identify the conflicting compose fragment. Add SPEC-M10 for resolved service references and SPEC-M11 for short names from the shared runtime catalogue. Findings follow the existing warn/error/off rollout and retain source/variant attribution.

Document manifest inheritance and version semantics, move historical repository counts into a dated baseline, and derive the flexible Compose type from the shared definition so current shared types compile correctly.

Related: #367. Coordinate rollout with Shared schema/runtime; publish the shared schema/type updates first. Companion documentation: Public docs and Tropibot guide.

Validation:

  • Full lint and TypeScript build pass on current master.
  • Unit suite: 173 passing, 1 pending on Node 26.
  • Integration against the corrected shared schemas/types: build and 15 spec tests pass; strict validation accepts the runtime’s legacy globalEnvs: { all: true } form.
  • Read-only checks of BIND, IPFS and all three local Nethermind variants produce no SPEC-M05/M10/M11 findings.

@3alpha
3alpha requested a review from a team as a code owner November 11, 2026 11:04
@3alpha 3alpha added the enhancement New feature or request label Nov 11, 2026
@3alpha
3alpha merged commit 1f937dd into master Nov 12, 2026
13 checks passed
@3alpha
3alpha deleted the fix/manifest-spec-validation branch November 12, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant