Repository navigation
fix: point Gnosis explorer links at beaconchain.gnosischain.com - #451
Merged
Merged
Conversation
gnosischa.in no longer resolves, so every Gnosis explorer link was broken. beaconchain.gnosischain.com serves /validator/<pubkey>. That explorer redirects /dashboard?validators=... to an empty /dashboard, and Lukso's explorer (Dora) has no dashboard page. Only build dashboard links for mainnet and Hoodi, and disable the dashboard button elsewhere with a tooltip pointing to the per-validator links.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #440.
Problem
Gnosis explorer links point at
https://gnosischa.in, which no longer resolves (NXDOMAIN on 1.1.1.1 and 8.8.8.8). Every "view in explorer" link and the dashboard button on Gnosis go nowhere. The URL proposed in #440,beacon.gnosisscan.io, doesn't resolve either.Change
https://beaconchain.gnosischain.com. It serves/validator/<pubkey>, the format the per-row links use: a real key loads its validator page.dashboardNetworksinparams.ts)./dashboard?validators=…and its newer/dashboard/<key>format to an empty/dashboard, without setting a cookie, so the selection is lost./dashboardreturns 404.buildValidatorSummaryURLreturns no link.The mainnet and Hoodi dashboard links are unchanged. beaconcha.in sits behind a Cloudflare bot check, so they couldn't be re-verified by script.
Tests
testBuildSummaryUrl.test.tsnow checks that mainnet and Hoodi build dashboard links, that Gnosis and Lukso build none, and that the Gnosis explorer URL is the new one. Lint, build and all UI tests (66) pass.