Repository navigation
Conversation
Follow the CPU fix in _process_linear_opposed(): highlights_initmask_linear tests each channel against its own clip level instead of red against all three.
da-phil
approved these changes
Nov 1, 2026
Contributor
|
Good catch, thank you for fixing it. |
Contributor
Author
Thanks! It came up while porting the linear opposed path to OpenCL. |
TurboGit
added
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22894 and #22895, which both merged today. #22895 fixed the CPU mask in
_process_linear_opposed()to test each channel against its own clip level. The OpenCL kernel from #22894 still tests red against all three, so on master, CPU and OpenCL disagree on linear raws with clipped highlights. This makeshighlights_initmask_linearmatch the CPU.Tested on a LinearRaw DNG made from hlrecovery.arw (greens clip, default opposed mode), PoCL:
No release note: both #22894 and #22895 are in this cycle, so no release had the mismatch.
Not tested: a discrete GPU.
Written with Claude Code.