Repository navigation
Define deploy and destroy approval prompts in one table - #7354
Draft
janniklasrose wants to merge 1 commit into
Draft
janniklasrose wants to merge 1 commit into
janniklasrose wants to merge 1 commit into
Conversation
Deploy and destroy each kept their own list of groups that get a consent prompt, so a group added to one could silently miss the other. Both lists now derive from one table, and a test names the groups that have no destroy prompt. Co-authored-by: Isaac <no-reply@databricks.com>
janniklasrose
added
the
new-resource-work
Collaborator
Integration test reportCommit: c4bcedb
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
bundle deployandbundle destroyeach kept their own list of resource groups that get a data-loss confirmation prompt, with a message per group. Both lists now derive from one table inbundle/phases/approval.go: each entry carries the group, its deploy message, the deploy-onlyskipChildrenflag, and an optional destroy message. Deploy's order and messages are unchanged; destroy's list is the same subsequence as before, including itsskipChildrendefault.A new test requires a deploy message for every entry and names the groups that have no destroy prompt, with a comment for each. Adding a group to one command only is now a visible choice rather than an omission. No message text changes.
Why
A group added to one list and not the other got a prompt in one command only, and nothing detected it.
Tests
go test ./bundle/phases/... -count=1, including the newTestApprovalTableEntries.bundle/destroy,genie_spaces,features/basic,materialization_sets/basic,dms/declined-deploy,vector_search_indexes,postgres_databases) pass without regenerating goldens.This pull request and its description were written by Isaac.