Skip to content

Use an obviously fake connection string in the pgx advisory test fixture - #7357

Merged
pietern merged 1 commit into
mainfrom
scrub-pgx-fixture-connection-string
Nov 4, 2026
Merged

pietern merged 1 commit into
mainfrom
scrub-pgx-fixture-connection-string

Conversation

@pietern

@pietern pietern commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Replaces the example DATABASE_URL in tools/repoadvisory/testdata/pgx.json with postgres://FAKE_USER:FAKE_PASSWORD@db.example:5432/FAKE_DB, so nobody mistakes it for a real credential.

This pull request and its description were written by Isaac.

Co-authored-by: Isaac <no-reply@databricks.com>
@pietern
pietern requested a review from a team as a code owner November 4, 2026 15:56
@pietern
pietern enabled auto-merge November 4, 2026 16:00
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 171c0ac

Run: 41862853058

Env ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 271 15 6:41
✅​ aws-windows-latest-4core-16gb 273 13 4:04
✅​ azure linux-2core-8gb 270 15 5:20
✅​ azure-windows-latest-4core-16gb 272 13 3:35
✅​ gcp linux-2core-8gb 271 15 5:25
✅​ gcp-windows-latest-4core-16gb 273 13 3:37
Top 3 slowest tests (at least 2 minutes):
duration env testname
3:35 aws-windows-latest-4core-16gb TestAccept
3:29 azure-windows-latest-4core-16gb TestAccept
3:27 gcp-windows-latest-4core-16gb TestAccept

@pietern
pietern added this pull request to the merge queue Nov 4, 2026
Merged via the queue into main with commit 964664a Nov 4, 2026
28 checks passed
@pietern
pietern deleted the scrub-pgx-fixture-connection-string branch November 4, 2026 16:37
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 964664a

Run: 41869371882

Env ❌​FAIL ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 17 1500 1255 239:38
❌​ aws-windows-latest-4core-16gb 19 1417 1282 244:17
✅​ azure linux-2core-8gb 1364 1307 120:36
✅​ azure-windows-latest-4core-16gb 1283 1334 133:23
✅​ gcp linux-2core-8gb 1351 1312 126:10
✅​ gcp-windows-latest-4core-16gb 1270 1339 146:20
22 interesting tests: 22 FAIL
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb
❌​ TestAccept ❌​F ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent ❌​F ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN= ❌​F ✅​p
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1 ❌​F ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN= ❌​F ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1 ✅​p ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN= ❌​F ❌​F
❌​ TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1 ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN= ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1 ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN= ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1 ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN= ❌​F ❌​F
❌​ TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1 ❌​F ❌​F
❌​ TestAccept/bundle/invariant/no_drift ❌​F ❌​F
❌​ TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN= ✅​p ❌​F
❌​ TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1 ✅​p ❌​F
❌​ TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN= ✅​p ❌​F
❌​ TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1 ✅​p ❌​F
❌​ TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster.yml.tmpl/READPLAN= ❌​F ✅​p
❌​ TestAccept/bundle/invariant/no_drift/DMS=true/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN= ❌​F ✅​p
Top 50 slowest tests (at least 2 minutes):
duration env testname
18:21 aws linux-2core-8gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1
17:17 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=
13:42 aws linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=
13:27 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
11:51 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
10:55 aws linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
10:18 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=1
9:28 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=1
9:26 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:20 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
9:18 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
9:14 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
9:06 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1
8:58 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:55 aws-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=
8:50 aws linux-2core-8gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
8:43 azure linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:40 gcp-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
8:35 azure-windows-latest-4core-16gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
8:34 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
8:33 aws linux-2core-8gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
8:28 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
8:23 azure-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:19 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
8:17 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
8:11 gcp-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=
8:09 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=
8:09 aws-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started-toggle/DMS=
7:50 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
7:49 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:43 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=true
7:40 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=
7:39 aws-windows-latest-4core-16gb TestAccept/bundle/deploy/spark-jar-task/DMS=true
7:36 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=1
7:35 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:33 gcp linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started/DMS=true
7:33 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_libraries.yml.tmpl/READPLAN=
7:32 gcp linux-2core-8gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=true
7:16 aws linux-2core-8gb TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS=true
7:09 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=
7:06 aws-windows-latest-4core-16gb TestAccept/bundle/invariant/no_drift/DMS=/INPUT_CONFIG=cluster.yml.tmpl/READPLAN=
7:05 gcp linux-2core-8gb TestAccept/bundle/invariant/delete_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
7:05 aws linux-2core-8gb TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DMS=true
7:04 gcp-windows-latest-4core-16gb TestAccept/bundle/invariant/destroy_idempotent/DMS=/INPUT_CONFIG=cluster_apply_policy_default_values.yml.tmpl/READPLAN=
6:59 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/local_ssd_count/DMS=
6:57 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/update-after-create/DMS=true
6:55 aws linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=true
6:51 aws-windows-latest-4core-16gb TestAccept/bundle/resources/clusters/deploy/simple/DMS=true
6:50 gcp linux-2core-8gb TestAccept/bundle/config-remote-sync/multiple_resources/DMS=
6:45 gcp-windows-latest-4core-16gb TestAccept/bundle/resources/apps/lifecycle-started/DMS=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants