Skip to content

[FS-2621] Enable DMS for Feature and MaterializationSet in DAB #7369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Daniel114510 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[FS-2621] Enable DMS for Feature and MaterializationSet in DAB #7369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions acceptance/bundle/invariant/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ EnvMatrixExclude.no_model_service_on_cloud = ["CONFIG_Cloud=true", "INPUT_CONFIG
# Cloud coverage for data quality monitors comes from
# resources/data_quality_monitors/lifecycle; the invariant matrix runs locally.
EnvMatrixExclude.no_data_quality_monitor_on_cloud = ["CONFIG_Cloud=true", "INPUT_CONFIG=data_quality_monitor.yml.tmpl"]
# Deployment history has no "features." resource-key prefix, so the deploy fails before the feature
# is created; see dmsResourceTypes in libs/testserver/bundledeployments.go.
EnvMatrixExclude.no_feature_dms = ["DMS=true", "INPUT_CONFIG=feature.yml.tmpl"]
# Fake SQL endpoint for local tests

[[Server]]
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/features/basic/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/features/lifecycle/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = true
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/features/remote-delete/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
3 changes: 0 additions & 3 deletions acceptance/bundle/resources/features/test.toml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/basic/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/batch/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = true
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/destination/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/immutable/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = true
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
4 changes: 0 additions & 4 deletions acceptance/bundle/resources/materialization_sets/immutable/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Creates its own schema and deletes it on exit. Override MATSET_CATALOG where `main` is absent.
Cloud = true

# Both legs run locally. A cloud run must select the DMS= leg: the bundle deployments API
# rejects features. and materialization_sets. as resource-type prefixes.
EnvMatrix.DMS = ["", "true"]

Ignore = [
".databricks",
"databricks.yml",
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/invalid_members/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/membership/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
4 changes: 0 additions & 4 deletions acceptance/bundle/resources/materialization_sets/membership/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@
# its own schema and deletes it on exit.
Cloud = false

# Both legs run locally. A cloud run must select the DMS= leg: the bundle deployments API
# rejects features. and materialization_sets. as resource-type prefixes.
EnvMatrix.DMS = ["", "true"]

Ignore = [
".databricks",
"databricks.yml",
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/mixed_triggers/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/removal_scope/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = true
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
4 changes: 0 additions & 4 deletions acceptance/bundle/resources/materialization_sets/removal_scope/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
# Creates its own schema and deletes it on exit. Override MATSET_CATALOG where `main` is absent.
Cloud = true

# Both legs run locally. A cloud run must select the DMS= leg: the bundle deployments API
# rejects features. and materialization_sets. as resource-type prefixes.
EnvMatrix.DMS = ["", "true"]

Ignore = [
".databricks",
"databricks.yml",
Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/sawtooth/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
2 changes: 1 addition & 1 deletion acceptance/bundle/resources/materialization_sets/streaming/out.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Cloud = false
EnvMatrix.DMS = [""]
EnvMatrix.DMS = ["", "true"]
5 changes: 0 additions & 5 deletions acceptance/bundle/resources/materialization_sets/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,3 @@ Ignore = [
"databricks.yml",
".databricks",
]

# Deployment history has no "materialization_sets." or "features." resource-key prefix, so the
# deploy fails before anything is created. See dmsResourceTypes in
# libs/testserver/bundledeployments.go, which mirrors the service's allowlist.
EnvMatrixExclude.no_matset_dms = ["DMS=true"]
2 changes: 2 additions & 0 deletions libs/testserver/bundledeployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,14 @@ var dmsResourceTypes = []string{
"database_instances",
"experiments",
"external_locations",
"features",
"genie_spaces",
"instance_pools",
"internal_immutable_folders",
"internal_immutable_snapshots",
"job_runs",
"jobs",
"materialization_sets",
"mcp_services",
"model_provider_services",
"model_services",
Expand Down
Loading