Repository navigation
MaterializationSet in DAB: Test the recreate approval for mutating a materialization set member's membership key field - #7370
Open
Daniel114510 wants to merge 2 commits into
Open
Daniel114510 wants to merge 2 commits into
Daniel114510 wants to merge 2 commits into
Conversation
… recreating the set The immutable case now deploys both changes. Each plans a recreate, a deploy that cannot prompt stops at the set's approval message, and with approval the set is rebuilt and plans clean. The rename also prints the warning that the member is not in the deployed set; the trigger change keeps the member key, so it recreates through the trigger's immutable rule without that warning. Co-authored-by: Isaac <no-reply@databricks.com>
Daniel114510
changed the title
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=0 unreleased=0 coverage=1 failing=0
|
…r references The phase points the set's materialized feature member at featb's feature name instead of feata's; neither Feature View's own full name changes. Its titles, template name and template comments now say so, rather than calling it a renamed member. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: ee209e5
Top 3 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extends the
materialization_sets/immutableacceptance case to include:--auto-approverebuilds the set.--auto-approverebuilds the set.Both fields (feature name, trigger) is part of the composite key of a materialized feature member of a materialization set.
Why
The existing acceptance tests for materialization set does not contain changing the fields of a materialized feature that constitute its composite key leads to recreate.
Tests
materialization_sets/immutable— passed locallyfs2621-dms-feature-matsetapplied — passed on bothDMSlegs