Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 13 not selected) 35 tests: regression=31 unreleased=0 coverage=4 failing=0
TestAccept/bundle/migrate/auto/registered-model-rename/DMS=: branch ✅ | main (eb1328d) ❌ | latest (v1.24.0) ❌main (eb1328d): latest (v1.24.0): same output as main (eb1328d) TestAccept/bundle/migrate/auto/schema-rename/DMS=: branch ✅ | main (eb1328d) ❌ | latest (v1.24.0) ❌main (eb1328d): latest (v1.24.0): same output as main (eb1328d) TestAccept/bundle/resources/catalogs/rename/DMS=: branch ✅ | main (eb1328d) ❌ | latest (v1.24.0) ❌main (eb1328d): latest (v1.24.0): TestAccept/bundle/resources/catalogs/rename/DMS=true: branch ✅ | main (eb1328d) ❌ | latest (v1.24.0) ❌main (eb1328d): latest (v1.24.0): TestAccept/bundle/resources/catalogs/rename_all_out_of_band/DMS=: branch ✅ | main (eb1328d) ❌ | latest (v1.24.0) ❌main (eb1328d): latest (v1.24.0): 26 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: 5bd3516
Top 7 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/models-rename
branch
from
November 6, 2026 11:17
18077b3 to
7716c7e
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 11:21
344a6c9 to
24b12d9
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 6, 2026 11:58
7716c7e to
eb6d7fe
Compare
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 11:58
24b12d9 to
35b8737
Compare
denik
force-pushed
the
denik/models-rename
branch
from
November 6, 2026 12:25
eb6d7fe to
d397965
Compare
UC moves a secret with its renamed parent, so the planner now re-keys it (update_id, parent_renamed) instead of recreating it, which failed with ALREADY_EXISTS. A secret cannot be renamed itself, so its DoUpdateWithID only re-keys; the adapter check now accepts DoUpdateWithID for a resource whose provided_id_fields a parent rename can change. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/secrets-parent-rename
branch
from
November 6, 2026 12:25
35b8737 to
5bd3516
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A UC secret in a renamed catalog or schema (
schema_name: ${resources.schemas.<s>.name}) now follows its parent the way volumes do in #7343 and registered models do in #7379: it is re-keyed without a request. It used to be planned as a recreate whose create failed with409 ALREADY_EXISTS(verified on AWS), and every later deploy tried to create it again.UC cannot rename a secret, so its name still recreates. The secret's new
DoUpdateWithIDonly re-keys it, and sends the update at the new path when the secret also has its own changes. The adapter check used to requireupdatable_id_fieldsfor aDoUpdateWithID; it now also acceptsprovided_id_fields, which a parent rename can change.The test server now moves secrets when their schema or catalog is renamed.
Stacked on #7379.
Tests
secrets/parent_rename(Cloud = true; passes locally and on AWS, GCP and Azure): rename the schema (no request to the secret), then rename the catalog and change the secret's comment in one deploy (one PATCH at the new path).create_timestays the same and the final plan is a no-op.This pull request and its description were written by Isaac.