Repository navigation
Add .workspace.URLID and fix review findings on .workspace - #7388
Open
pavloKozlov wants to merge 1 commit into
Open
pavloKozlov wants to merge 1 commit into
pavloKozlov wants to merge 1 commit into
Conversation
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 2 tests: regression=2 unreleased=0 coverage=0 failing=0
TestAccept/bundle/templates-machinery/workspace_variable/runtime/DMS=: branch ✅ | main (663e1f7) ❌ | latest (v1.24.0) ❌main (663e1f7): latest (v1.24.0): TestAccept/bundle/templates-machinery/workspace_variable/runtime/DMS=true: branch ✅ | main (663e1f7) ❌ | latest (v1.24.0) ❌main (663e1f7): latest (v1.24.0): |
Collaborator
✅ Integration test reportCommit: ae38015
|
- Add .workspace.URLID: the workspace ID that .workspace.URL adds as ?w=, or empty. Unlike .workspace.ID, it doesn't fail when the ID is unknown and doesn't return an ID from host metadata. - Schema rendering keeps the default of an input that has a value when the default fails to render, instead of failing. bundle init doesn't use that default, so the same input works there. - Add setup_custom_host to acceptance/script.prepare for the test server reached as a host shared by several workspaces, and use it in workspace_variable. - The runtime test covers URLID per profile, a failing default of an input with a value, the w and workspace_id selectors and a protocol-relative path. - Doc comments name where URLID comes from, and the missing ID error names the bundle's workspace_id. Co-authored-by: Isaac <no-reply@databricks.com>
pavloKozlov
force-pushed
the
workspace-context-review-fixes
branch
from
November 6, 2026 14:13
966af61 to
ae38015
Compare
pavloKozlov
changed the base branch from
workspace-context-builtin-templates
to
main
November 6, 2026 14:13
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds
.workspace.URLID: the workspace ID that.workspace.URLadds as?w=, or empty. Unlike.workspace.ID, it doesn't fail when the ID is unknown and doesn't return an ID from host metadata, so templates can use it for optional parts such as the?o=that dbt needs.Schema rendering keeps the default of an input that has a value when that default fails to render, instead of failing the whole render.
bundle initnever uses that default, so it already worked there.Adds
setup_custom_hosttoacceptance/script.preparefor tests that reach the test server as a host shared by several workspaces.Why
Review comments on #7350, which builds on this, and a follow-up review of #7349.
Tests
The
workspace_variableruntime test printsURLIDfor each kind of profile, and covers a failing default of an input with a value, every rejected workspace selector, and a protocol-relative path.This pull request and its description were written by Isaac.