Repository navigation
Upgrade go-runewidth to v0.0.31 to cut CLI startup time - #7391
Open
stevenchen-db wants to merge 2 commits into
Open
stevenchen-db wants to merge 2 commits into
stevenchen-db wants to merge 2 commits into
Conversation
v0.0.26 and v0.0.27 build a 2.2 MB rune-width lookup table in init(), which costs ~30ms on every CLI invocation. v0.0.31 builds it lazily. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
✅ Integration test reportCommit: f82bbd6
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Upgrade the indirect dependency
github.com/mattn/go-runewidthfrom v0.0.27 to v0.0.31.v0.0.26 and v0.0.27 build a 2.2 MB rune-width lookup table in
init(), which adds ~30ms to every CLI invocation before any command runs. v0.0.31 builds it lazily on first use.Tests
GODEBUG=inittrace=1: runewidth init 30ms → 0.02ms.databricks --versionmedian of 21 runs: 55.1ms → 22.3ms.mainlocally.This pull request and its description were written by Isaac.