Repository navigation
Skip the lowercased read-back of a feature's full_name - #7398
Draft
Daniel114510 wants to merge 3 commits into
Draft
Daniel114510 wants to merge 3 commits into
Daniel114510 wants to merge 3 commits into
Conversation
UC lowercases a feature's name, and create and get return it that way. Listing full_name in provided_id_fields skips that read-back difference, as it does for schemas and feature specs, so a mixed-case full_name no longer recreates the feature on every plan. The fake lowercases the name like the real endpoint. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 1 changed tests (limit=20, 0 not selected) 1 tests: regression=1 unreleased=0 coverage=0 failing=0
TestAccept/bundle/resources/features/uppercase-name/DMS=: branch ✅ | main (21db1be) ❌ | latest (v1.24.0) ❌main (21db1be): latest (v1.24.0): same output as main (21db1be) |
Collaborator
❌ Integration test reportCommit: 5bd66aa
Top 1 slowest tests (at least 2 minutes):
|
UC stores a feature's name lowercase and the service requires a set member to name its feature that way, while a member's feature_name keeps the config spelling, whether it is written out, a reference to a feature, or built from a schema resource's name. So a mixed-case member was rejected at create, and a set holding one planned a recreate on every deploy. - MaterializedFeatureMemberKey lowercases the feature name, so a mixed-case member pairs with its lowercase read-back. A name holding an unresolved reference keeps its case, since resource keys are case-sensitive. - OverrideChangeDesc skips the feature_name of a paired member, which can then differ only in case. - DoCreate and DoUpdate send a copy of the set with each member's feature name lowercased. - The test server's set create refuses a member that does not name its feature in lowercase, with the service's message. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UC lowercases a feature's name, and create and get return it that way. Listing full_name in provided_id_fields skips that read-back difference, as it does for schemas and feature specs, so a mixed-case full_name no longer recreates the feature on every plan. The fake lowercases the name like the real endpoint.
Changes
Why
Tests