Repository navigation
Add interactive pickers to aitools mcp add and remove - #7552
Draft
simonfaltum wants to merge 15 commits into
Draft
simonfaltum wants to merge 15 commits into
simonfaltum wants to merge 15 commits into
Conversation
Contributor
|
Commit: Regression test reportSelected 19 changed tests (limit=20, 0 not selected) 19 tests: regression=19 unreleased=0 coverage=0 failing=0
TestAccept/cmd/aitools/mcp/add-agent-not-installed: branch ✅ | main (bf8caad) ❌ | latest (v1.26.0) ❌main (bf8caad): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-default-config: branch ✅ | main (bf8caad) ❌ | latest (v1.26.0) ❌main (bf8caad): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-name-notices: branch ✅ | main (bf8caad) ❌ | latest (v1.26.0) ❌main (bf8caad): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-remove-agent-clis: branch ✅ | main (bf8caad) ❌ | latest (v1.26.0) ❌main (bf8caad): latest (v1.26.0): TestAccept/cmd/aitools/mcp/add-text: branch ✅ | main (bf8caad) ❌ | latest (v1.26.0) ❌main (bf8caad): latest (v1.26.0): 14 more failure details omitted, see the full report in the run. |
simonfaltum
changed the base branch from
aitools-mcp/07-login
to
aitools-mcp/08-challenge
November 12, 2026 13:02
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 13:02
f9ffc67 to
2dd54b7
Compare
Collaborator
✅ Integration test reportCommit: 828e6f7
Top 13 slowest tests (at least 2 minutes):
|
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
from
November 12, 2026 14:42
38cdd13 to
1d8e6b3
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 14:44
2dd54b7 to
a1fd867
Compare
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
from
November 12, 2026 17:14
1d8e6b3 to
7b98424
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 12, 2026 17:15
a1fd867 to
b90afff
Compare
simonfaltum
force-pushed
the
aitools-mcp/08-challenge
branch
2 times, most recently
from
November 13, 2026 07:25
1c6aee6 to
7a9dca9
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
2 times, most recently
from
November 13, 2026 12:28
0aa2ee4 to
2dbdfe3
Compare
simonfaltum
changed the base branch from
aitools-mcp/08-challenge
to
aitools-mcp/08b-agent-clis
November 13, 2026 12:28
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 13, 2026 13:28
1fff1da to
e9bad5b
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 13, 2026 15:06
3ed1398 to
8cca61b
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 13, 2026 15:06
b30caa0 to
43a64fd
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 16, 2026 12:47
43a64fd to
b12f2bf
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
2 times, most recently
from
November 16, 2026 13:19
50318b1 to
f46d6a0
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 16, 2026 13:19
b12f2bf to
1ee83b9
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 16, 2026 13:32
f46d6a0 to
d049189
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
2 times, most recently
from
November 16, 2026 14:49
29624cd to
a7c5766
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
2 times, most recently
from
November 16, 2026 15:14
6955d59 to
84abb41
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
2 times, most recently
from
November 16, 2026 15:53
52a1885 to
e652cdf
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 17, 2026 10:52
190f3cb to
fdc9d71
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 17, 2026 10:52
e652cdf to
793107d
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 17, 2026 11:21
fdc9d71 to
fc23170
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
2 times, most recently
from
November 17, 2026 12:02
a3a8757 to
27ecba1
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 17, 2026 12:02
fc23170 to
0d214eb
Compare
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 17, 2026 12:36
27ecba1 to
8047e0c
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 17, 2026 12:36
0d214eb to
2a05c5e
Compare
mcp add and mcp remove prompt for the profile, the services and the location when run in a terminal without flags. The agent picker and the proceed prompt are shared with install. The picker prompts use one help text, and a declined prompt ends with the same cancelled message. Main's install flow keeps its own scope title and plan output. The mcp add picker uses the global scope, which is the scope mcp add reports. Co-authored-by: Isaac <no-reply@databricks.com>
main bumped github.com/spf13/pflag to 1.1.0 (#7635), which prints boolean flags as --force[=true|false] in help output and widens the flag column. Co-authored-by: Isaac <no-reply@databricks.com>
remove now shows a picker in a terminal, so its help in the help golden says how the servers are chosen there. Co-authored-by: Isaac <no-reply@databricks.com>
The service picker wrapped rows that had long API comments, and huh counts one line per option, so the cursor left the screen past about row 14 at 80x24 and never scrolled back. A row is now the leaf name, a description and its tags, on one line of at most the terminal width. The description falls back from the CLI's Summary to its Label to the first sentence of the API comment, with markdown links removed, and it is cut with an ellipsis when the row is too long. The tags always show. Co-authored-by: Isaac <no-reply@databricks.com>
The picker opened on its first pre-checked row, and huh scrolled that row into view. Recommended services sit below the others in the API order, so on a profile with eighteen services the first seven were hidden with nothing to show they were there. Recommended services now come first, in API order within each group, so the picker opens at the top with them still pre-checked. Co-authored-by: Isaac <no-reply@databricks.com>
Proceed? came after the picker with nothing to say what it would remove, and the result only appeared afterwards. The remove picker now prints a plan first, in the style of the add plan: one line per agent, with the servers removed from it. With --agents, only the named agents are listed. Co-authored-by: Isaac <no-reply@databricks.com>
Esc did nothing in the service, remove and sign-in pickers and the location prompt, so only Ctrl+C left them. Esc now cancels them as Ctrl+C does, with the same user aborted result. While a multi-select searches, the first Esc only leaves the search. The help line of a multi-select now says that typed keys go to the search, and how to leave it, and it shows the schema in the help line rather than in the title. The title used to read "in system.ai/drive" once the search was left, since huh shows an applied filter after the title. The profile picker's rows show the host on every row, and the active row has the ▸ marker and underline that the cmdio select uses. Co-authored-by: Isaac <no-reply@databricks.com>
Card 02 replaced the SignInRequired field of mcp.Service with a method derived from OAuthProvider. Test services that need sign-in now set an OAuthProvider. Co-authored-by: Isaac <no-reply@databricks.com>
An agent whose config cannot be read is refused like an uninstalled one, through the refused map, so the picker's agents are refused too and no request is sent for them. The plan line test follows that, and the merge uses maps.Copy. Co-authored-by: Isaac <no-reply@databricks.com>
The mcp commands confirmed their plan through the confirm that install uses, which did not read Esc. Esc did nothing at Proceed?, so only Ctrl+C left it. mcp add and mcp remove now ask through promptMCPProceed, a picker that defaults to yes and cancels on Esc as Ctrl+C does, and its help line says so. The confirm was the only caller of promptProceed on this base, so the install copy is removed rather than left unused, which the linter rejects. Co-authored-by: Isaac <no-reply@databricks.com>
This card replaces addRequest.explicit with agentSource. Co-authored-by: Isaac <no-reply@databricks.com>
The --location help and the Long help name the case with no leaf names, as the review changed them. The golden for the help comes from the review, so it is regenerated here. Co-authored-by: Isaac <no-reply@databricks.com>
This card replaces addRequest.explicit with agentSource. Picked and detected agents keep the writer's own read-only message. Co-authored-by: Isaac <no-reply@databricks.com>
simonfaltum
force-pushed
the
aitools-mcp/09-pickers
branch
from
November 17, 2026 15:11
8047e0c to
828e6f7
Compare
simonfaltum
force-pushed
the
aitools-mcp/08b-agent-clis
branch
from
November 17, 2026 15:11
2a05c5e to
1c32739
Compare
…omparison mcp add and remove now skip their prompts for a coding agent, as install does, and draw the pickers on stderr, so a redirected stdout no longer hides a prompt. The plan compares a Databricks entry with agentconfig.Changed instead of a copy of its comparison, and a bad entry fails only its own agent. The remove refusal says "selected" again, since it is also true when the agent has other servers, and the regexps compile on first use. Co-authored-by: Isaac <no-reply@databricks.com>
…ts from the host agent mcp add's plan shows a Databricks entry that cannot be compared as an update and leaves the error to the write, which names the file, so the run no longer stops before its requests. The picker tests start from an empty environment, so a test run inside a coding agent sees no terminal prompts. The terminal width comment names stderr. Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of the stack that adds the hidden
databricks aitools mcpcommand group. It sits on #7595, which adds and removes agent MCP entries through each agent's own CLI.databricks aitools mcp addandremovestopped in a terminal with "interactive selection is not available yet" when a flag was missing. This PR replaces that stopgap with pickers. Runs without a terminal keep their flags and output.Changes
addasks for the profile, the services and the agents that the flags do not give. The profile resolves as it does without a terminal, so the picker runs only where that stops with several profiles.(installed), unchecked. "Another schema..." lists another catalog and schema and keeps the checks.add,re-assert(only when the write leaves the entry as it is),updateorreplace. An agent whose config cannot be read is shown with the reason.addasksProceed?only when a picker made a choice. For each sign-in-required server it installed, it asks "Sign in now?" unless the caller is already signed in. Ctrl-C stops the remaining questions and prints the login command of each server still to sign in.removewith none of--names,--profileor--allshows the installed servers and asksProceed?before removing the picked ones.Why
Choosing servers needs their descriptions and sign-in requirements, which the workspace knows and the flags do not show.
Decisions to review
add --namesdoes.--namewithout--namesis refused rather than offered a single-select picker.add --helptext changed, so thehiddengolden changed. Theremoverefusal wording changed inrepair-and-warnings. No other non-interactive output changed.Tests
mcp_pickers_test.gocovers the service and profile pickers, the agent picker's failed check and the remove picker's refusal.mcp_add_test.goruns an interactiveaddthrough the prompt seams: refusals make no request, a changed host is refused after the pick, two schemas install, and a fully specified run asks only the sign-in question. It also covers the plan lines and a hung credential read.mcp_remove_test.goruns the remove picker end to end, including a declined confirmation.libs/aitools/mcp/binding_test.gocovers the profile check of a run without a service.go test -race ./cmd/aitools/ ./libs/aitools/... ./libs/cmdio/,./task test-exp-aitoolsandgo test ./acceptance -run TestAccept/cmd/aitoolspass.GOOS=windowsvet passes.This pull request and its description were written by Isaac.