Repository navigation
Conversation
`resources.apps.<key>.thumbnail_path` points at a local PNG or JPEG image that `bundle deploy` uploads as the app's thumbnail in the Apps UI. The Apps API can't return the image, so the direct engine keeps only a hash of it in state (hashed_fields): an unchanged file makes no API call, new content uploads only the thumbnail (no app update), and removing the field deletes the thumbnail. The file is checked when the bundle is loaded, so `bundle validate` already rejects files that aren't PNG or JPEG (by signature, like the API) or are larger than 250,000 bytes, the limit of the Apps UI and of the Terraform provider's databricks_app.thumbnail_path. Co-authored-by: Isaac <no-reply@databricks.com>
fjakobs
force-pushed
the
fjakobs/app-thumbnail
branch
from
November 17, 2026 16:29
bb827e0 to
8eac7c0
Compare
Contributor
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 8 tests: regression=8 unreleased=0 coverage=0 failing=0
TestAccept/bundle/refschema/DMS=: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): TestAccept/bundle/refschema/DMS=true: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): TestAccept/bundle/resources/apps/thumbnail-invalid/DMS=: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): same output as main (a07d81e) TestAccept/bundle/resources/apps/thumbnail-invalid/DMS=true: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): same output as main (a07d81e) TestAccept/bundle/resources/apps/thumbnail-upload-fails/DMS=: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): same output as main (a07d81e) TestAccept/bundle/resources/apps/thumbnail-upload-fails/DMS=true: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): same output as main (a07d81e) TestAccept/bundle/resources/apps/thumbnail/DMS=: branch ✅ | main (a07d81e) ❌ | latest (v1.26.0) ❌main (a07d81e): latest (v1.26.0): same output as main (a07d81e) 1 more failure details omitted, see the full report in the run. |
Collaborator
✅ Integration test reportCommit: c670d2f
Top 28 slowest tests (at least 2 minutes):
|
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New
resources.apps.<key>.thumbnail_path: path of a local PNG or JPEG image, relative to the file that defines the app.bundle deployuploads it as the app's thumbnail in the Apps UI (PATCH /api/2.0/apps/{name}/thumbnail).thumbnail_url, so the direct engine keeps a hash of it in state (hashed_fields, as fordashboards.serialized_dashboard). An unchanged file makes no API call. New content uploads only the thumbnail, without an app update. Removing the field deletes the thumbnail (DELETE .../thumbnail). A bundle that never sets the field leaves a thumbnail uploaded in the UI alone.bundle validaterejects a missing file, a file that isn't PNG or JPEG (detected by its signature, as the API does), or one over 250,000 bytes.Why
Apps can have a thumbnail, but bundles had no way to set it.
thumbnail_pathfollows the_pathnaming of other local-file fields (source_code_path,file_path). It is also the name of the matchingdatabricks_appargument in Add thumbnail_path to databricks_app terraform-provider-databricks#6196.Tests
bundle/resources/apps/thumbnailrecords the requests for: create plus upload, an unchanged redeploy (no thumbnail request), new content (thumbnail upload only),deploy --planfrom a saved plan (uploads the image, not its hash), removal (delete), and destroy.thumbnail-invalidcoversbundle validateerrors.thumbnail-upload-failscovers the warn-and-retry path on create../task fmt,./task checksand./task lint,go test ./bundle/... ./libs/testserver/...and the full local acceptance suite.thumbnail_url.GET /apps/{name}.PATCH .../thumbnail.bundle validate.DELETE .../thumbnail.This pull request and its description were written by Isaac.