Repository navigation
fix(deps): dedupe @internationalized/date so the version-bump typecheck passes - #103
Open
polylane[bot] wants to merge 1 commit into
Open
polylane[bot] wants to merge 1 commit into
polylane[bot] wants to merge 1 commit into
Conversation
…ck passes Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
ecv
approved these changes
Oct 27, 2026
ecv
left a comment
Contributor
There was a problem hiding this comment.
Approve.
Lockfile-and-resolutions change only, as claimed: one new resolutions entry plus the matching yarn.lock collapse of three ranges into a single 3.12.4 entry. Typecheck, test, lint, kind-e2e and Trivy are green at 75505b1.
^3.12.4satisfies every dependent range (^3.12.0,^3.12.1,^3.12.2, and react-aria/react-stately at^3.12.4); same major,3.12.4is the currentlateston npm.- It does not hold anything off a fix: it is a floor, so later 3.x releases are still allowed, and the lock moves forward from 3.12.2, not back.
- The new entry sits after the
uuidones inpackage.jsonand is not grouped with them; harmless.
Follow-ups:
- The resolution is permanent. Once react-aria and
@backstage/uiboth require^3.12.4or newer naturally, drop it so it cannot mask a future major bump.
scotwells
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every weekly Backstage version-bump run failed its typecheck, so the automated upgrade pull request stayed a draft and could not be reviewed. The failure came from how the upgraded dependency set resolved one date library. After this merges, the bump run typechecks cleanly and its pull request can be marked ready.
Detection evidence
Affected:
int_17ad4b457001o98datdn4tkmWhy this fix
The bump branch installs two versions of @internationalized/date: @backstage/ui 0.19.0 needs ^3.12.0, while the react-aria and react-stately versions it pulls in need ^3.12.4. With two copies, the date value types are nominally different and @backstage/ui's date picker types do not compile. Forcing a single version through the existing resolutions block removes the duplicate. I reproduced the failure on the bump tree and confirmed the typecheck then passed, and that on main the install stays immutable and the typecheck is clean. The remaining risk is a future bump that needs a newer major, when the range must move with it.
Production impact: Dependency dedupe changes no production resource behavior
I checked the datum-cloud/backstage repository; the infrastructure graph records no deployed resource for it, so this change reaches only the build. The bump dependency set drops from two @internationalized/date copies to one, and the main install with
yarn install --immutableandyarn tsc:fullpasses.Checked and not affected:
provider#code#account#datum-cloud#region#earth#type#code.repository#id#datum-cloud/backstage.Observability
typecheckjob in thevalidatereusable workflow: the signal this change corrects.Polylane assessed this pull request at
75505b1.Fix walkthrough
Watch the fix explained (1:25). Recorded for commit
75505b16fc18247d9c5bfd7dadda4b43210fe969.Causal chain
2 files changed (+6/-5)
package.json: modified, +2/-1yarn.lock: modified, +4/-4Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment.