Repository navigation
fix(geo): normalize region aliases before allocating indexes - #11962
Open
embrace897 wants to merge 1 commit into
Open
embrace897 wants to merge 1 commit into
embrace897 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Region names are normalized only when writing generated Go tables. If the input contains both an alias and its canonical name, such as 黑龙 and 黑龙江, the generator allocates distinct indexes but emits duplicate map keys, making the generated file fail to compile.
Normalize region names before encoding them so aliases share one index. Add a regression covering both supported alias pairs.
Validation: the original generator fails the regression and its generated Go file fails to compile with duplicate map keys. With the patch, the Python regression and compilation of generated output with the production GeoInfo definition pass. Full geo/server tests and production-dataset validation were not run.
Prepared with AI assistance.