Repository navigation
fix(automation): return a failing exit code on runner errors - #11964
Open
embrace897 wants to merge 1 commit into
Open
embrace897 wants to merge 1 commit into
embrace897 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Socket.IO runner error callback raises an assertion on a background thread. The client can still exit with status 0 after disconnecting, so the workflow step can report success when the runner sends an error.
Record the failure before disconnecting and return a nonzero exit status from the main thread after the wait completes.
Validated with a local Socket.IO server and the pinned client dependencies. The original client exits 0 on an error. The patched client exits 1 on an error and 0 on a finish event. The hosted workflow was not run.
Prepared with AI assistance.