Repository navigation
fix(client): copy custom headers before adding the session id - #825
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
GregHolmes,
deepgram-kiley and
dg-coreylweathers
as code owners
November 3, 2026 15:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeepgramClientandAsyncDeepgramClientaddx-deepgram-session-iddirectly to theheadersdict that the caller passes in. The generated client wrapper stores a reference to that dict, so clients built from one shared dict all send the session ID of the last client created, and the caller's dict changes.This change copies
headersbefore the session header is added, in both clients.Changes
src/deepgram/client.py: copy the caller'sheadersinto a new dict before settingx-deepgram-session-id.tests/custom/test_client_construction_and_helpers.py: add a test that builds two clients from one shared dict and checks that each client sends its ownsession_idand that the shared dict is unchanged.Testing
main(2 failed: the first client sends the second client's session ID) and passes with the fix (2 passed).pytest tests/custom tests/utils: 1081 passed, 1 skipped.ruff checkandmypypass on the changed files.Fixes #824