Repository navigation
Pass non-bind/volume --mount values to the container runtime - #1353
Open
Aleksei Gmitron (agmitron) wants to merge 1 commit into
Open
Aleksei Gmitron (agmitron) wants to merge 1 commit into
Aleksei Gmitron (agmitron) wants to merge 1 commit into
Conversation
`devcontainer up --mount` only accepted `type=<bind|volume>,source=,target=[,external=]` and rebuilt the value as `type=,src=,dst=`, so `type=image`, `subpath`, `readonly`, `tmpfs` and other runtime options were rejected or dropped. Values in the bind/volume form keep being parsed as before. Any other value is now passed to `--mount` of the runtime verbatim, the same way string entries in `devcontainer.json` `mounts` are. The Docker Compose path converts mounts to the short `source:target` syntax, so it rejects such a value with an explicit error instead of silently losing its options. Fixes devcontainers#1352 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devcontainer up --mountonly acceptedtype=<bind|volume>,source=,target=[,external=]and rebuilt the value astype=,src=,dst=, sotype=image,subpath,readonly,tmpfsand other runtime options were rejected or dropped.Values in the bind/volume form keep being parsed as before. Any other value is now passed to
--mountof the runtime verbatim, the same way string entries indevcontainer.jsonmountsare. The Docker Compose path converts mounts to the shortsource:targetsyntax, so it rejects such a value with an explicit error instead of silently losing its options.Fixes #1352