Repository navigation
[node] - Fix for missing library - #1769
Open
Kaniska (v-Kaniska244) wants to merge 1 commit into
Open
Kaniska (v-Kaniska244) wants to merge 1 commit into
Kaniska (v-Kaniska244) wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Node.js runtime dependency update.
No open issues 🎉
What changed in this PR
Fixes missing Node.js runtime dependencies in the Node dev container feature, including when nodeGypDependencies is disabled.
Changes:
- Installs the appropriate atomic runtime package on supported Linux distributions.
- Expands runtime dependency and Corepack coverage, accommodates Yarn’s npm fallback, and makes LTS assertions dynamic.
- Documents runtime dependencies and Yarn behavior, and bumps the feature version to
2.1.2.
| File | Description |
|---|---|
test/node/ubuntu_yarn_from_corepack.sh |
Adds Ubuntu Corepack and Yarn checks. |
test/node/scenarios.json |
Adds Node 24 Corepack scenarios and disables build dependencies in runtime checks. |
test/node/install_node_debian_trixie.sh |
Checks libatomic and npm; handles both Yarn installation paths. |
test/node/install_node_debian_bookworm.sh |
Handles Corepack and npm-installed Yarn. |
test/node/install_additional_node.sh |
Compares the active Node version with nvm’s LTS version. |
test/node/install_additional_node_on_rhel_family.sh |
Uses a dynamic LTS assertion on RHEL-family systems. |
test/node/fedora.sh |
Adds libatomic and npm checks. |
test/node/debian_yarn_from_corepack.sh |
Checks Corepack availability and exact Yarn version. |
src/node/NOTES.md |
Documents the runtime dependency and Yarn installation behavior. |
src/node/install.sh |
Installs distribution-specific atomic runtime packages. |
src/node/devcontainer-feature.json |
Bumps the feature version to 2.1.2. |
Review effort: Balanced
Kaniska (v-Kaniska244)
marked this pull request as ready for review
November 6, 2026 13:54
Abdurrahmaan Iqbal (abdurriq)
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing
libatomic.so.1runtime dependencies in the Node.js Feature, particularly whennodeGypDependenciesis disabled.This release also improves Yarn/Corepack compatibility for newer Node.js versions and makes the test suite resilient to changing LTS versions.
Changes
libatomic1libatomiclibgcc-atomicnpmand the atomic runtime package in relevant distribution tests.2.1.1to2.1.2.Testing
The following validation completed successfully:
Compatibility
This is a backwards-compatible fix. Existing Node.js, npm, pnpm, Yarn, nvm, and Feature options remain unchanged. The additional runtime packages are installed automatically where required.