Skip to content

Fill in hostent fields in gethostbyname/gethostbyaddr/gethostent - #9254

Open
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-13-gethostent
Open

tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-13-gethostent

Conversation

@tautschnig

@tautschnig tautschnig commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

The three hostent models returned a pointer to a zero-initialised
struct hostent on the success path. Since h_addr_list was NULL,
code that walks the address list (the main use of these functions)
was never analysed, hiding reachable assertions (soundness bug).

POSIX.1-2017 netdb.h specifies h_addr_list as a pointer to an array
of pointers to network addresses, terminated by a null pointer. The
models now set h_name to a valid (empty) string, h_aliases to a
NULL-terminated list, and h_addr_list to a NULL-terminated list with
one 4-byte address entry.

Fixes #9312

Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 11:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

The three hostent models returned a pointer to a zero-initialised
struct hostent on the success path.  Since h_addr_list was NULL,
code that walks the address list (the main use of these functions)
was never analysed, hiding reachable assertions (soundness bug).

POSIX.1-2017 netdb.h specifies h_addr_list as a pointer to an array
of pointers to network addresses, terminated by a null pointer.  The
models now set h_name to a valid (empty) string, h_aliases to a
NULL-terminated list, and h_addr_list to a NULL-terminated list with
one 4-byte address entry.

Reported by Jeroen Robben (https://reports.robben.io/methodology/).

Fixes diffblue#9312

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
@tautschnig
tautschnig force-pushed the kiro/rr-1-13-gethostent branch from 5c391bd to 04da381 Compare October 28, 2026 11:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants