Repository navigation
Fill in hostent fields in gethostbyname/gethostbyaddr/gethostent - #9254
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
October 28, 2026 11:02
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
The three hostent models returned a pointer to a zero-initialised struct hostent on the success path. Since h_addr_list was NULL, code that walks the address list (the main use of these functions) was never analysed, hiding reachable assertions (soundness bug). POSIX.1-2017 netdb.h specifies h_addr_list as a pointer to an array of pointers to network addresses, terminated by a null pointer. The models now set h_name to a valid (empty) string, h_aliases to a NULL-terminated list, and h_addr_list to a NULL-terminated list with one 4-byte address entry. Reported by Jeroen Robben (https://reports.robben.io/methodology/). Fixes diffblue#9312 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
kiro/rr-1-13-gethostent
branch
from
October 28, 2026 11:39
5c391bd to
04da381
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three hostent models returned a pointer to a zero-initialised
struct hostent on the success path. Since h_addr_list was NULL,
code that walks the address list (the main use of these functions)
was never analysed, hiding reachable assertions (soundness bug).
POSIX.1-2017 netdb.h specifies h_addr_list as a pointer to an array
of pointers to network addresses, terminated by a null pointer. The
models now set h_name to a valid (empty) string, h_aliases to a
NULL-terminated list, and h_addr_list to a NULL-terminated list with
one 4-byte address entry.
Fixes #9312
Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).