Skip to content

C library: pthread_rwlock_rdlock must allow concurrent readers - #9257

Open
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-17-rwlock-rdlock
Open

tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-17-rwlock-rdlock

Conversation

@tautschnig

@tautschnig tautschnig commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

pthread_rwlock_rdlock used __CPROVER_assume(!lock), which blocks while
any lock is held, including a read lock. Thus a second reader blocked,
and all executions in which two threads hold a read lock at the same
time were excluded. POSIX.1-2017 pthread_rwlock_rdlock(): "A thread
may hold multiple concurrent read locks on rwlock". Only block while a
writer holds the lock (bit 2), and set the reader bit (bit 1).

The previously KNOWNBUG regression test is now CORE.

Fixes #9316

Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 11:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

pthread_rwlock_rdlock used __CPROVER_assume(!lock), which blocks while
any lock is held, including a read lock. Thus a second reader blocked,
and all executions in which two threads hold a read lock at the same
time were excluded. POSIX.1-2017 pthread_rwlock_rdlock(): "A thread
may hold multiple concurrent read locks on rwlock". Only block while a
writer holds the lock (bit 2), and set the reader bit (bit 1).

The previously KNOWNBUG regression test is now CORE.

Reported by Jeroen Robben (https://reports.robben.io/methodology/).

Fixes diffblue#9316

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
@tautschnig
tautschnig force-pushed the kiro/rr-1-17-rwlock-rdlock branch from 1fa3506 to 13c431d Compare October 28, 2026 11:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C library model: pthread_rwlock_rdlock model blocks forever on a second read lock, so later assertions are vacuously verified

2 participants