Repository navigation
C library: pthread_rwlock_rdlock must allow concurrent readers - #9257
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
October 28, 2026 11:03
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
pthread_rwlock_rdlock used __CPROVER_assume(!lock), which blocks while any lock is held, including a read lock. Thus a second reader blocked, and all executions in which two threads hold a read lock at the same time were excluded. POSIX.1-2017 pthread_rwlock_rdlock(): "A thread may hold multiple concurrent read locks on rwlock". Only block while a writer holds the lock (bit 2), and set the reader bit (bit 1). The previously KNOWNBUG regression test is now CORE. Reported by Jeroen Robben (https://reports.robben.io/methodology/). Fixes diffblue#9316 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
kiro/rr-1-17-rwlock-rdlock
branch
from
October 28, 2026 11:39
1fa3506 to
13c431d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pthread_rwlock_rdlock used __CPROVER_assume(!lock), which blocks while
any lock is held, including a read lock. Thus a second reader blocked,
and all executions in which two threads hold a read lock at the same
time were excluded. POSIX.1-2017 pthread_rwlock_rdlock(): "A thread
may hold multiple concurrent read locks on rwlock". Only block while a
writer holds the lock (bit 2), and set the reader bit (bit 1).
The previously KNOWNBUG regression test is now CORE.
Fixes #9316
Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).