Skip to content

Fix fesetround model to reject invalid rounding modes - #9265

Open
tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-27-fesetround
Open

tautschnig wants to merge 1 commit into
diffblue:developfrom
tautschnig:kiro/rr-1-27-fesetround

Conversation

@tautschnig

@tautschnig tautschnig commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

The fesetround library model unconditionally set __CPROVER_rounding_mode
to round-to-nearest (0) and returned 0 for any argument not matching a
rounding-direction macro. This violates:

  • C11 7.6.3.2p2: if the argument is not equal to the value of a
    rounding direction macro, the rounding direction is not changed.
  • C11 7.6.3.2p3: fesetround returns zero if and only if the requested
    rounding direction was established.

The model now leaves _CPROVER_rounding_mode unchanged and returns -1
when the argument does not match any FE
* macro.

Fixes #9326

Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 11:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.

The fesetround library model unconditionally set __CPROVER_rounding_mode
to round-to-nearest (0) and returned 0 for any argument not matching a
rounding-direction macro. This violates:
- C11 7.6.3.2p2: if the argument is not equal to the value of a
  rounding direction macro, the rounding direction is not changed.
- C11 7.6.3.2p3: fesetround returns zero if and only if the requested
  rounding direction was established.

The model now leaves __CPROVER_rounding_mode unchanged and returns -1
when the argument does not match any FE_* macro.

Reported by Jeroen Robben (https://reports.robben.io/methodology/).

Fixes diffblue#9326

Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
@tautschnig
tautschnig force-pushed the kiro/rr-1-27-fesetround branch from 0f1e61c to 9ee546b Compare October 28, 2026 11:39

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C library model: fesetround() model resets the mode to round-to-nearest and returns 0 for an argument that is not a rounding-direction macro

2 participants