Repository navigation
Fix fesetround model to reject invalid rounding modes - #9265
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
tautschnig
requested review from
kroening,
peterschrammel and
remi-delmas-3000
as code owners
October 28, 2026 11:03
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
The fesetround library model unconditionally set __CPROVER_rounding_mode to round-to-nearest (0) and returned 0 for any argument not matching a rounding-direction macro. This violates: - C11 7.6.3.2p2: if the argument is not equal to the value of a rounding direction macro, the rounding direction is not changed. - C11 7.6.3.2p3: fesetround returns zero if and only if the requested rounding direction was established. The model now leaves __CPROVER_rounding_mode unchanged and returns -1 when the argument does not match any FE_* macro. Reported by Jeroen Robben (https://reports.robben.io/methodology/). Fixes diffblue#9326 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
kiro/rr-1-27-fesetround
branch
from
October 28, 2026 11:39
0f1e61c to
9ee546b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fesetround library model unconditionally set __CPROVER_rounding_mode
to round-to-nearest (0) and returned 0 for any argument not matching a
rounding-direction macro. This violates:
rounding direction macro, the rounding direction is not changed.
rounding direction was established.
The model now leaves _CPROVER_rounding_mode unchanged and returns -1
when the argument does not match any FE* macro.
Fixes #9326
Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).