Repository navigation
SMT2: parse values of bit-fields - #9278
Open
tautschnig wants to merge 1 commit into
Open
tautschnig wants to merge 1 commit into
tautschnig wants to merge 1 commit into
Conversation
tautschnig
requested review from
TGWDB,
kroening,
martin-cs and
peterschrammel
as code owners
October 28, 2026 11:05
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
smt2_convt::parse_rec had no case for c_bit_field types and returned nil, so traces showed bit-field members as "(assignment removed)". Parse the value using the integer type of the bit-field's width and signedness (c_bit_field_replacement_type), and restore the bit-field type. This only affects counterexample traces of the SMT2 back ends, not verification results. Reported by Jeroen Robben (https://reports.robben.io/methodology/). Fixes diffblue#9346 Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
tautschnig
force-pushed
the
kiro/rr-2-16-smt2-parse-bitfield
branch
from
October 28, 2026 11:39
e97893d to
634bb4b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
smt2_convt::parse_rec had no case for c_bit_field types and returned
nil, so traces showed bit-field members as "(assignment removed)".
Parse the value using the integer type of the bit-field's width and
signedness (c_bit_field_replacement_type), and restore the bit-field
type.
This only affects counterexample traces of the SMT2 back ends, not
verification results.
Fixes #9346
Found by Jeroen Robben's specification-conformance pipeline (https://reports.robben.io/methodology/).