Repository navigation
Include the recognised entity for vc-recognition matches - #71
Merged
ottonomy merged 1 commit intoOct 20, 2026
Conversation
This was referenced Oct 14, 2026
The vc-recognition handler kept only a yes or no from the verified recognition credential's subject. It now returns the matching credentialSubject entry as the match's entity: name, url and logo from the entry's members of those names, each only where the entry's value is a string, and the whole entry as raw. The credential is verified before its subject is read, on a cache hit as well as on a fresh fetch, so the entity is as trusted as the membership itself. The mapping follows the OIDF handler's: a name that is a language map or an object yields no entity.name and stays readable through raw, as does anything else the entry holds. The RegistryEntity type comment, the README, the verification-results guide, the architecture doc and the CHANGELOG no longer say vc-recognition matches carry no entity. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ottonomy
force-pushed
the
nightshift/50-include-the-recognised-entity-for-vc-recognition
branch
from
October 20, 2026 19:23
9c27657 to
051e19c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Stacked on #70 — review and merge that first (or merge the stack together).
Departures
None. The handler now returns the recognised
credentialSubjectentry as thematch's
entity, mapped the way the OIDF handler maps itsmetadata, and thefive places that said vc-recognition matches carry no entity have been
rewritten.
Decisions not in the issue
subjectContainsDidbecamefindSubjectEntry, returning the matching entryrather than a boolean, and the array and single-object subject shapes are now
handled by one
findover a one-element array instead of two branches. Thebehaviour for a missing or non-object subject is unchanged.
entityFromEntry, mirroring the name andthe doc-comment shape the OIDF and dcc-legacy handlers already use, rather
than being shared between handlers: the three mappings read different source
shapes and nothing is deduplicated by pulling them together.
foundresult withtoEqual, so theynow carry the expected
entitytoo. New tests cover the stringurl/logocase alongside an unmapped
image, an entry with noname, an entry whosename,urlandlogoare a language map / object / array, and a secondlookup served from the handler's cache.
result.entity, as the OIDF spec does:HandlerResultis a union whosenot-foundmember has noentity, so reading the property directly wouldadd a type error to the dev type-check.
vc-recognition-handler.tswas leftalone; the OIDF line next to it does not mention entities either, and the
prose section further down carries the description.
Agent-Run: b8b4ceec-5ec2-4bd8-8aa4-f7b4617ddde8