Skip to content

LAD serialiser/Deserialiser - #956

Open
RagdAhmed wants to merge 4 commits into
digraphs:mainfrom
RagdAhmed:add-lad-format
Open

RagdAhmed wants to merge 4 commits into
digraphs:mainfrom
RagdAhmed:add-lad-format

Conversation

@RagdAhmed

Copy link
Copy Markdown

No description provided.

@Joseph-Edwards Joseph-Edwards added the VIP Pull requests done by participants of the VIP programme. label Oct 14, 2026
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (8d49e9a) to head (1d8153d).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #956      +/-   ##
==========================================
+ Coverage   97.45%   97.47%   +0.02%     
==========================================
  Files          50       53       +3     
  Lines       21189    21465     +276     
  Branches      639      638       -1     
==========================================
+ Hits        20649    20924     +275     
- Misses        475      477       +2     
+ Partials       65       64       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @RagdAhmed ! The failing CI is unrelated to the changes in this PR (some internet issue). There are no tests, or documentation, both of which are required before we review this properly, can you please add tests and doc?

Also I wonder if it would be appropriate to add detection of .lad to the machinery in ReadDigraphs and WriteDigraphs so that it's possible to "auto" detect this format? If anything is unclear, please ask at the next meeting!

Fixed error formatting and adds validation for checking that the digraph does not contain a loop
@james-d-mitchell

Copy link
Copy Markdown
Member

Thanks @RagdAhmed ! Can you please fix the issues that are causing the CI to fail? I think this is primarily the linting, the other failing jobs are just due to internet failures it looks like, so re-running those when you update the linting we should expect them to pass.

Comment thread doc/io.xml
</Description>
</ManSection>
<#/GAPDoc>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add <#Include Label="LADString"> in one of the files z-chap*.xml, otherwise the documentation you've written here is never actually picked up.

@mtorpey mtorpey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from @james-d-mitchell's comment from just now, I'm happy to merge.

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change then I'm happy to merge this. It'd be good to add a link to the LAD format wherever it was first formulated, but I only found:

https://perso.citi-lab.fr/csolnon/

on

https://github.com/ciaranm/glasgow-subgraph-solver,

but the link above doesn't resolve to anything for me, so for now let's skip it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VIP Pull requests done by participants of the VIP programme.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants