Repository navigation
Conversation
…aphs and LAD format
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 97.45% 97.47% +0.02%
==========================================
Files 50 53 +3
Lines 21189 21465 +276
Branches 639 638 -1
==========================================
+ Hits 20649 20924 +275
- Misses 475 477 +2
+ Partials 65 64 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
left a comment
There was a problem hiding this comment.
Thanks for the contribution @RagdAhmed ! The failing CI is unrelated to the changes in this PR (some internet issue). There are no tests, or documentation, both of which are required before we review this properly, can you please add tests and doc?
Also I wonder if it would be appropriate to add detection of .lad to the machinery in ReadDigraphs and WriteDigraphs so that it's possible to "auto" detect this format? If anything is unclear, please ask at the next meeting!
Fixed error formatting and adds validation for checking that the digraph does not contain a loop
|
Thanks @RagdAhmed ! Can you please fix the issues that are causing the CI to fail? I think this is primarily the linting, the other failing jobs are just due to internet failures it looks like, so re-running those when you update the linting we should expect them to pass. |
| </Description> | ||
| </ManSection> | ||
| <#/GAPDoc> | ||
|
|
There was a problem hiding this comment.
You also need to add <#Include Label="LADString"> in one of the files z-chap*.xml, otherwise the documentation you've written here is never actually picked up.
mtorpey
left a comment
There was a problem hiding this comment.
Aside from @james-d-mitchell's comment from just now, I'm happy to merge.
james-d-mitchell
left a comment
There was a problem hiding this comment.
One minor change then I'm happy to merge this. It'd be good to add a link to the LAD format wherever it was first formulated, but I only found:
https://perso.citi-lab.fr/csolnon/
on
https://github.com/ciaranm/glasgow-subgraph-solver,
but the link above doesn't resolve to anything for me, so for now let's skip it.
No description provided.