Skip to content

Add DigraphMaximalQuotients - #959

Merged
mtorpey merged 7 commits into
digraphs:mainfrom
boriforizs:add-digraphs-maximal-quotients
Nov 12, 2026
Merged

mtorpey merged 7 commits into
digraphs:mainfrom
boriforizs:add-digraphs-maximal-quotients

Conversation

@boriforizs

Copy link
Copy Markdown
Contributor

No description provided.

@mtorpey

mtorpey commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

A bit of a failure in the tests here, as you can see, e.g. at this link.

You'll notice in the tst files that there's a list of local variables at the top, and it looks like you need to add mq to that. Give it a try and see if you can get tests passing.

(You can add more commits to this PR by simply adding them to the branch and pushing.)

@mtorpey

mtorpey commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Other things to work on:

  • Add documentation for DigraphMaximalQuotients, in doc/attr.xml and an appropriate z-chap file. You can see what's done for other functions by looking through those.
  • Add a comment to your code to indicate the bit that is probably not optimal (comparing Bliss canonical reps).
  • Start work on a version that uses DigraphHash and see if it speeds things up.
  • Abstract out the more generic operation DigraphsUpToIsomorphism.

Hopefully this gives you some stuff to work on till next meeting. Thanks for emailing me!

@james-d-mitchell james-d-mitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes required, then I'll be happy to merge this, thank you @boriforizs !

Comment thread gap/attr.gi Resolved
Comment thread doc/attr.xml Resolved
Comment thread gap/attr.gi Resolved
Comment thread doc/attr.xml Resolved
@mtorpey mtorpey added the VIP Pull requests done by participants of the VIP programme. label Oct 28, 2026
@mtorpey
mtorpey self-requested a review November 11, 2026 15:01
mtorpey
mtorpey previously approved these changes Nov 11, 2026

@mtorpey mtorpey left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke to @boriforizs about this just now. I like the state of things, just want to see tests pass before merging.

@mtorpey
mtorpey dismissed james-d-mitchell’s stale review November 11, 2026 15:02

Requested changes complete. (MY)

@james-d-mitchell james-d-mitchell changed the title Add DigraphMaximalQuotients Add DigraphMaximalQuotients Nov 11, 2026
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (d94d17b) to head (3ee0365).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #959   +/-   ##
=======================================
  Coverage   97.47%   97.48%           
=======================================
  Files          53       53           
  Lines       21466    21493   +27     
  Branches      638      638           
=======================================
+ Hits        20925    20952   +27     
  Misses        477      477           
  Partials       64       64           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtorpey
mtorpey merged commit e767816 into digraphs:main Nov 12, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

VIP Pull requests done by participants of the VIP programme.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants