Repository navigation
Add miscellaneous missing docs - #960
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #960 +/- ##
==========================================
- Coverage 97.48% 97.47% -0.01%
==========================================
Files 53 53
Lines 21363 21424 +61
Branches 639 638 -1
==========================================
+ Hits 20825 20883 +58
- Misses 473 477 +4
+ Partials 65 64 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
james-d-mitchell
requested changes
Oct 26, 2026
james-d-mitchell
left a comment
Member
There was a problem hiding this comment.
A couple of minor TODOs, then we'll be happy to merge, thanks @William-Kenyon this is super helpful!
Co-authored-by: James Mitchell <james-d-mitchell@users.noreply.github.com>
james-d-mitchell
previously approved these changes
Nov 4, 2026
james-d-mitchell
left a comment
Member
There was a problem hiding this comment.
Looks good to me @mtorpey can you also have a wee look?
mtorpey
reviewed
Nov 4, 2026
mtorpey
left a comment
Collaborator
There was a problem hiding this comment.
One tiny improvement to be made, along with the comma in the failing test. After that, let's merge!
Comment on lines
+13
to
+16
| DeclareOperation("EdgeWeightedDigraph", | ||
| [IsDigraph and IsMutableDigraph, IsList]); | ||
| DeclareOperation("EdgeWeightedDigraph", | ||
| [IsDigraph and IsImmutableDigraph, IsList]); |
Collaborator
There was a problem hiding this comment.
This can be just one operation, with [IsDigraph, IsList] as the filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used a small script to find instances where
Declare...("name", ...)existed but had no corresponding mansection, i.e. no<Oper/Attr/Prop/... name="name" ...>, and updated the docs where appropriate. Excluding...Cons,...NC,DIGRAPHS_...etc.