Skip to content

Add a random source argument to the RandomDigraph function - #963

Open
heloiseconolly wants to merge 5 commits into
digraphs:mainfrom
heloiseconolly:random-source
Open

heloiseconolly wants to merge 5 commits into
digraphs:mainfrom
heloiseconolly:random-source

Conversation

@heloiseconolly

Copy link
Copy Markdown

I rewrote the original C code for RANDOM_DIGRAPH into GAP to avoid the use of the non-reproducible rand() function in C. Additionally, I added an optional random source argument to RandomDigraph.

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (8771b99) to head (55aedbc).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
gap/digraph.gi 92.85% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (94.44%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
- Coverage   97.47%   97.37%   -0.11%     
==========================================
  Files          51       53       +2     
  Lines       21349    21444      +95     
  Branches      639      638       -1     
==========================================
+ Hits        20811    20882      +71     
- Misses        473      498      +25     
+ Partials       65       64       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@heloiseconolly heloiseconolly changed the title Added a random source argument to the RandomDigraph function Add a random source argument to the RandomDigraph function Nov 5, 2026
@heloiseconolly
heloiseconolly marked this pull request as ready for review November 11, 2026 16:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant