Repository navigation
Acknowledge the reality of securityContext handling - #198
Merged
cfis merged 2 commits intoOct 27, 2026
Merged
Conversation
tdg5
commented
Apr 1, 2026
| # set those unless you're using a secret | ||
| #RELAY_PASSWORD: | ||
|
|
||
| securityContext: |
Contributor
Author
There was a problem hiding this comment.
I verified against v5.1.1 that this does not work. The pod won't start with this config.
cfis
added a commit
to cfis/docker-mailserver-helm
that referenced
this pull request
Oct 27, 2026
deployment.securityContext is now applied (docker-mailserver#198), which changes the pod for anyone who had set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This change is released as part of 6.0.0 (docker-mailserver 16) since applying deployment.securityContext changes behavior for anyone who had set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Thanks for this @tdg5, and sorry for the very slow reply! I've merged your change, it will be in 6.0.0 which already has backwards incompatible changes. I agree on keeping |
cfis
added a commit
to cfis/docker-mailserver-helm
that referenced
this pull request
Oct 27, 2026
deployment.securityContext is now applied (docker-mailserver#198), which changes the pod for anyone who had set it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cfis
added a commit
to radicand/docker-mailserver-helm
that referenced
this pull request
Oct 27, 2026
Releases docker-mailserver 16 (docker-mailserver#199), the securityContext fix (docker-mailserver#198) and the dms-healthcheck probes together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been touched on elsewhere, but I wanted to make it official to try to save other people time and confusion.
This PR does 2.5 things:
coalescethat prioritizes takingsecurityContextconfig from.deployment.securityContext, but falls back to.securityContextto try to maintain existing mappings.coalesceas part of 6.x release.securityContextconfig with an empty object to try to maintain existing default configuration and be honest about what's really happening upon deployment.If you disagree with any of these choices, let me know. Feedback is welcome.
Related: