Repository navigation
Upgrade CI and test infrastructure to Helm 4 - #200
Merged
Merged
Conversation
Move CI to Helm 4 and pin every tool so results don't change between runs. The unittest and chart-testing jobs used whatever Helm came with the runner image, and helm-unittest was installed unpinned from git. Since snapshot output depends on the helm-unittest version, a new plugin release broke the snapshot tests on master without any chart change. * Helm 3.19.0 -> 4.3.1, set up explicitly in all three jobs * helm-unittest pinned to 1.2.1 (installed with --verify=false, as Helm 4 requires for plugins installed from git) * kube-score 1.17.0 -> 1.20.0 * kind node images 1.32/1.33/1.34 -> 1.35.8/1.36.4/1.37.0, the images for kind 0.33 which kind-action 1.15.1 uses * actions/checkout v4 -> v7, actions/setup-python v5 -> v7 (Python 3.11 -> 3.13), azure/setup-helm 4.3.0 -> 5.0.1, chart-testing-action 2.7.0 -> 2.9.0, kind-action 1.5.0 -> 1.15.1 * Replace the deprecated ::set-output with $GITHUB_OUTPUT * Also run the workflow when .ci/ changes * Publish: set skip_existing so merges that don't bump the chart version (docs, tests, CI) don't fail re-releasing an existing version * Pin the chart-testing image used by local-ct-lint.sh * Regenerate snapshots with helm-unittest 1.2.1, which renders env entries without a value that the old snapshots were missing * TESTING.md: list the current jobs, fix the badge, and document running and updating the unit tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves CI to Helm 4 and updates and pins the rest of the CI and test tooling.
Why
The
unittestandchart-testingjobs didn't set up Helm, so they used whatever version came with the runner image, and helm-unittest was installed from git without a version. Snapshot output depends on the helm-unittest version, so a plugin release broke the snapshot tests onmasterwith no chart change: the current helm-unittest renders env entries that have no value (value: null), which the existing snapshots don't have. Any PR that touches the templates currently failsunittest.Changes
Also:
::set-outputwith$GITHUB_OUTPUT..ci/changes.skip_existingon chart-releaser. Merges that changecharts/without bumping the chart version (docs, tests, CI) currently fail trying to re-release the existing version. The last publish run onmasterfailed, most likely for this reason (its logs have expired)..ci/scripts/local-ct-lint.sh.TESTING.md: lists the current jobs, fixes the badge (it pointed at the old repo's workflows), and documents running and updating the unit tests with the pinned helm-unittest version.Notes
helmbinary, andct lintpasses locally with Helm 4.3.1.ct installis exercised by this PR's CI run.--verify=falseon Helm 4.Testing
helm unittestpasses with Helm 4.3.1 and helm-unittest 1.2.1.ct lintpasses in thequay.io/helmpack/chart-testing:v3.15.0image with Helm 4.3.1.#199 (docker-mailserver 16) will be rebased onto this once it's merged, so its snapshot changes only contain its own changes.
🤖 Generated with Claude Code